Repository navigation
Create CSV record handlers per opened file - #137
Merged
osipovartem merged 1 commit intoOct 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A shared CSV record handler cannot attribute decoded or malformed records to their source file in a multi-file scan. Consumers needing precise file-local diagnostics must currently build one scan per file. In a 128-file local COPY benchmark, that approach regressed p50 latency from 33.4 ms to 370.8 ms. The CSV opener already knows the object's path when it creates each reader, so an opt-in file-scoped handler avoids the per-file scan graph.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Additive public API only. Existing shared-handler and default CSV behavior are unchanged. No breaking API change.