Repository navigation
Use the standard harness for constraint regression tests - #255
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several constraint regression tests use dedicated Space subclasses and manual DFS for ordinary solution checks. Use the existing integer test harness for sparse tables, large bin-packing weights, modular-product reification, inactive implications, default linear expressions, and fixed-end cumulative schedules. Reuse existing limit-value GCD tests, add divisibility coverage at those limits, and remove duplicate minimum-distance and bin-packing checks.
Keep targeted tests that observe intermediate propagation strength, delayed wakeups, clone ownership, representation metadata, and API errors. Remove the cumulative scalar reference implementation and internal helper checks. Fix BoolExprInvalid so it fails if the required TooFewArguments exception is absent.
Validation: Release build passed; affected constraint suites passed; all 436 check-tag tests passed. Sparse-table samples include guaranteed accepted tuples, and small cases retain exhaustive assignment and reification coverage. Existing modular-product conventions for fixpoint checks are preserved.