Repository navigation
fix(SuperBuild): link nlohmann_json natvis file in the build tree - #1380
Merged
Merged
Conversation
With MSVC, nlohmann_json installs nlohmann_json.natvis at the root of its install directory and its exported target references it. The superbuild only links bin, lib, cmake, include and share into the build tree, so projects using the build tree as CMAKE_PREFIX_PATH failed to configure on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
BotellaA
approved these changes
Oct 22, 2026
|
🎉 This PR is included in version 19.1.1-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since json became an OpenGeode third party (784a9f5), projects that use the OpenGeode superbuild tree (
OpenGeode/build) asCMAKE_PREFIX_PATHfail to configure on Windows with MSVC:With MSVC, nlohmann_json installs
nlohmann_json.natvisat the root of its install directory and its exported target references it ($<INSTALL_INTERFACE:nlohmann_json.natvis>); it has no option to disable this. OpenGeode installs the file inopengeode/install/, but thepost_installtarget only linksbin,lib,cmake,includeandshareinto the build tree, so the file is missing there.Fix
With MSVC,
post_installalso linksnlohmann_json.natvisinto the build tree. Nothing changes with other compilers. The condition is the compiler, not the generator: Visual Studio and Ninja generators are both affected.Tests
build.ninjacontains the natvis link command.OpenGeode/build.🤖 Generated with Claude Code