Repository navigation
fix: close sockets when synchronous driver setup fails - #1482
Open
Shubham-Padkonde wants to merge 2 commits into
Open
Shubham-Padkonde wants to merge 2 commits into
Shubham-Padkonde wants to merge 2 commits into
Conversation
hessjcg
previously approved these changes
Oct 12, 2026
hessjcg
left a comment
hessjcg
left a comment
Member
There was a problem hiding this comment.
Nice work. Thank you for the contribution!
kgala2
previously approved these changes
Oct 12, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a synchronous driver raises after the connector opens its TLS socket, the failed connection leaves that socket open. Domain-based connections also retain it in the failover tracking list. For example, the pg8000 adapter raises
KeyErrorfor a missing database argument before handing the socket to the driver.Close the socket and remove it from failover tracking when driver setup raises, then preserve the existing exception and refresh behavior. Successful connections keep their sockets open and tracked.
Tests exercise the real pg8000 adapter failure for direct and domain connections; both regressions fail before the fix. The existing successful domain-connection test now also checks that its socket stays open.
Validation: