Repository navigation
feat(memorystore): migrate Redis client-side metrics sample to OTLP - #14686
Merged
Merged
Conversation
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the Redis client-side metrics implementation from GCP-specific OpenTelemetry exporters to standard OTLP exporters over gRPC, incorporating Google Cloud authentication and resource detection. It also updates the associated tests and dependencies, and replaces force-flush calls with proper shutdowns. The review feedback correctly identifies that the OTLP exporter endpoints should not include the 'https://' scheme, as gRPC handles transport security via channel credentials and the scheme can cause connection failures.
fosky94
force-pushed
the
otlp-migration
branch
3 times, most recently
from
October 26, 2026 18:57
f3a4ff8 to
9ce9d28
Compare
fosky94
force-pushed
the
otlp-migration
branch
from
October 26, 2026 18:59
9ce9d28 to
0284b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the Memorystore for Redis client-side metrics sample from deprecated Cloud Monitoring exporters to standard OpenTelemetry OTLP exporters targeting telemetry.googleapis.com:443, per b/575558307.