Repository navigation
Conversation
vs2013 didn't fully implement c++11. In particular, it is missing proper char16_t support, so it was no longer possible to use it to build hxcpp since: 523cee1 > D:/a/hxcpp/hxcpp/include\hx/LessThanEq.h(98) : error C2766: explicit specialization; 'hx::CompareTraits<unsigned short>' has already been defined > D:/a/hxcpp/hxcpp/include\hx/LessThanEq.h(93) : see previous definition of 'CompareTraits<unsigned short>' Since then, more char16_t initialisations have been added, and now constexpr is used, so the codebase has been incompatible with vs2013 for a long time.
I'm not really sure what the "Using specified MSVC Ver" path is for, it seems to treat the HXCPP_MSVC_VER as a path and sets the string value directly to HXCPP_MSVC. In that case ival should be null, since a path cannot be parsed as an int.
The version is printed already above
With vs2013 support dropped, this version will always be 19 so we no longer need to add it to differentiate object directories.
dimensionscape
added a commit
to openfl/libhxcpp
that referenced
this pull request
Oct 21, 2026
The previous four commits are HaxeFoundation/hxcpp#1428 by @tobil4sk. Its last commit, which drops the -19 suffix from object directories, is left out: Lime relies on that suffix, as the PR notes. Fixes #249
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vs2013 didn't fully implement c++11. In particular, it is missing proper char16_t support, so it was no longer possible to use it to build hxcpp since: 523cee1
Since then, more char16_t initialisations have been added, and now constexpr is used, so the codebase has been incompatible with vs2013 for a long time.
This eliminates all versions that produced
msvcrtbinaries, which also gets rid of the need to have suffixes on the object files like-18,-19. I would like to also get rid of the-19now that everything would be ucrt, but this would be a breaking change (e.g. lime relies on it). For now I only got rid of it in the obj directories, which should be safe.This would also deprecate
MSVC17+,MSVC18+, andMSVC19. I have kept them set in case some user xmls still reference them. We could do the same withMSVC_VERonce it stops being used by hxcpp.