Repository navigation
feat(core): add shared request timing collector and middleware #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChristianPavilonis
wants to merge
5
commits into
main
Choose a base branch
from
feat/shared-request-timing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9c03cc5
feat(core): add shared request timing collector and middleware
ChristianPavilonis ab44494
fix(core): harden request timing API and validation
ChristianPavilonis 878be47
Merge origin/main into feat/shared-request-timing
ChristianPavilonis 4dd6bf8
Clarify timing boundaries using the reviewer’s example, add three reg…
ChristianPavilonis 0185297
Fix request-timing Clippy failures across Rust 1.95 and 1.98.1 withou…
ChristianPavilonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| Run the full CI gate checks locally before pushing. Run all four commands sequentially and report any failures: | ||
| Run the full CI gate checks locally before pushing. Run all five commands sequentially and report any failures: | ||
|
|
||
| 1. `cargo fmt --all -- --check` | ||
| 2. `cargo clippy --workspace --all-targets --all-features -- -D warnings` | ||
| 3. `cargo test --workspace --all-targets` | ||
| 4. `cargo check --workspace --all-targets --features "fastly cloudflare"` | ||
| 4. `cargo test -p edgezero-core --doc` | ||
| 5. `cargo check --workspace --all-targets --features "fastly cloudflare"` | ||
|
|
||
| If any step fails, show the errors and suggest fixes. Do not proceed to the next step until the current one passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏ This gate only exists in CI:
scripts/run_tests.sh:36,.claude/commands/check-ci.mdand the "CI Gates" list inCLAUDE.mdall stop atcargo test --workspace --all-targets, which skips doctests. So a local "all gates pass" never runs thecompile_failtest that keeps the snapshot payload from escaping. Suggest addingcargo test -p edgezero-core --docto all three.