Repository navigation
Coverage with Julia >= 1.0 - #365
Open
PatrickHaecker wants to merge 2 commits into
Open
PatrickHaecker wants to merge 2 commits into
PatrickHaecker wants to merge 2 commits into
Conversation
added 2 commits
October 18, 2026 04:07
Covers reductions over empty and one-element arrays, `checked_mul` for `f == 0`, the generic `AbstractFloat` conversion of `Normed`, hashing of values that equal a `Rational` (which goes through `decompose`), `%` of a foreign `Real` type, and the deprecated `floattype` fallback. The reductions, the hashing and `%` behave the same for `Fixed` and `Normed`, so common test functions check them over many raw types and fractional bits.
`Normed{UInt8,f}` requires `1 <= f <= 8`, so after the checks for
`f <= 7` only `f == 8` remains and the final `0.0f0` could never be
returned.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 96.75% 98.87% +2.12%
==========================================
Files 7 7
Lines 800 799 -1
==========================================
+ Hits 774 790 +16
+ Misses 26 9 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the (hopefully) uncontroversial part of #350, i.e. all changes which close coverage gaps while not bumping the dependency of the Julia version.
#350 then sits on top of this PR and will become smaller once the current PR is merged.