Repository navigation
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
v-rudkovskiy
force-pushed
the
RVA/Fix-ProGuard-failure-caused-by-transitive-ph-base-reference
branch
from
October 20, 2026 15:26
8eb9ac1 to
79e8943
Compare
r-brown
approved these changes
Oct 20, 2026
r-brown
deleted the
RVA/Fix-ProGuard-failure-caused-by-transitive-ph-base-reference
branch
October 20, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the XMLDSig dependency upgrade, downstream NetLicensing-Core builds started
failing during ProGuard processing with the following error:
XMLDSigValidatorCustom used ValueEnforcer only to perform a null check.
This introduced a direct bytecode reference to an implementation class provided transitively by ph-base.
Consumers that override or otherwise provide a different ph-xmldsig dependency set may not include the required ph-base version. ProGuard then treats the unresolved reference as an error and stops the build.
This currently affects the NetLicensing-Core agent build and its DB compatibility smoke checks.
Solution
Replace:
with the standard Java equivalent:
The validation behavior remains unchanged, while the unnecessary direct runtime reference to ph-base is removed.