Skip to content

Fix ProGuard failure caused by transitive ph-base reference - #66

Merged
r-brown merged 1 commit into
masterfrom
RVA/Fix-ProGuard-failure-caused-by-transitive-ph-base-reference
Oct 20, 2026
Merged

r-brown merged 1 commit into
masterfrom
RVA/Fix-ProGuard-failure-caused-by-transitive-ph-base-reference

Conversation

@v-rudkovskiy

Copy link
Copy Markdown
Member

Problem

After the XMLDSig dependency upgrade, downstream NetLicensing-Core builds started
failing during ProGuard processing with the following error:

Warning: com.labs64.netlicensing.util.XMLDSigValidatorCustom: can't find referenced class com.helger.base.enforce.ValueEnforcer

XMLDSigValidatorCustom used ValueEnforcer only to perform a null check.
This introduced a direct bytecode reference to an implementation class provided transitively by ph-base.
Consumers that override or otherwise provide a different ph-xmldsig dependency set may not include the required ph-base version. ProGuard then treats the unresolved reference as an error and stops the build.
This currently affects the NetLicensing-Core agent build and its DB compatibility smoke checks.

Solution

Replace:

ValueEnforcer.notNull(aDoc, "Document");

with the standard Java equivalent:

Objects.requireNonNull(aDoc, "Document");

The validation behavior remains unchanged, while the unnecessary direct runtime reference to ph-base is removed.

@v-rudkovskiy
v-rudkovskiy requested a review from r-brown October 20, 2026 15:25
@v-rudkovskiy v-rudkovskiy self-assigned this Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 79e8943.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@v-rudkovskiy
v-rudkovskiy force-pushed the RVA/Fix-ProGuard-failure-caused-by-transitive-ph-base-reference branch from 8eb9ac1 to 79e8943 Compare October 20, 2026 15:26
@r-brown
r-brown merged commit eea24b7 into master Oct 20, 2026
5 checks passed
@r-brown
r-brown deleted the RVA/Fix-ProGuard-failure-caused-by-transitive-ph-base-reference branch October 20, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants