Skip to content

馃З Modernizer: Migrate SponsorDialog to Compose PreferenceDialog - #621

Merged
LeanBitLab merged 1 commit into
mainfrom
modernizer/sponsor-dialog-15663770475407667894
Oct 7, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
modernizer/sponsor-dialog-15663770475407667894

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

馃挕 What:
The custom SponsorDialog (originally implemented with an ad-hoc Dialog + Card + Column layout) has been migrated to use the standard PreferenceDialog wrapper.

馃帹 UI Standard:
This refactoring aligns SponsorDialog with the consistent Jetpack Compose preference styling used across all other settings dialogs, automatically managing margins, shape, and window properties properly while maintaining the exact same layout functionality.

馃敩 Verification:

  • ./gradlew :app:assembleStandardDebug succeeded.
  • ./gradlew :app:testStandardDebugUnitTest successfully executed with no regressions.
  • No hardcoded English strings or em dashes were introduced.

PR created automatically by Jules for task 15663770475407667894 started by @LeanBitLab

馃挕 What:
The custom `SponsorDialog` (originally implemented with an ad-hoc `Dialog` + `Card` + `Column` layout) has been migrated to use the standard `PreferenceDialog` wrapper.

馃帹 UI Standard:
This refactoring aligns `SponsorDialog` with the consistent Jetpack Compose preference styling used across all other settings dialogs, automatically managing margins, shape, and window properties properly while maintaining the exact same layout functionality.

馃敩 Verification:
- `./gradlew :app:assembleStandardDebug` succeeded.
- `./gradlew :app:testStandardDebugUnitTest` successfully executed with no regressions.
- No hardcoded English strings or em dashes were introduced.
@google-labs-jules

Copy link
Copy Markdown

馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@LeanBitLab
LeanBitLab merged commit 492cd00 into main Oct 7, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the modernizer/sponsor-dialog-15663770475407667894 branch October 7, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant