Skip to content

⚡ Bolt: Pre-compile Regex instances in spellchecker hot-path - #636

Merged
LeanBitLab merged 1 commit into
mainfrom
bolt-spellchecker-regex-optimization-3917702699552839353
Oct 9, 2026
Merged

LeanBitLab merged 1 commit into
mainfrom
bolt-spellchecker-regex-optimization-3917702699552839353

Conversation

@LeanBitLab

Copy link
Copy Markdown
Owner

💡 What: Extracted inline Regex instantiations for quotes and periods, as well as the String to Regex mapping for punctuation, into companion object private constants in AndroidWordLevelSpellCheckerSession.
🎯 Why: onGetSuggestionsInternal is a hot-path method called frequently during user typing. Creating new Regex objects inline on every call causes unnecessary object allocation and regex compilation overhead, increasing garbage collection pressure and latency.
📊 Expected Impact: Reduced memory allocation per keystroke and faster spellchecker suggestion lookups by reusing pre-compiled regex patterns.
🔬 Verification: Ran ./gradlew :app:assembleStandardDebug and ./gradlew :app:testStandardDebugUnitTest. Verified no regressions and no em dashes were used in the changes.


PR created automatically by Jules for task 3917702699552839353 started by @LeanBitLab

💡 What: Extracted inline `Regex` instantiations for quotes and periods, as well as the `String` to `Regex` mapping for punctuation, into `companion object` private constants in `AndroidWordLevelSpellCheckerSession`.
🎯 Why: `onGetSuggestionsInternal` is a hot-path method called frequently during user typing. Creating new `Regex` objects inline on every call causes unnecessary object allocation and regex compilation overhead, increasing garbage collection pressure and latency.
📊 Expected Impact: Reduced memory allocation per keystroke and faster spellchecker suggestion lookups by reusing pre-compiled regex patterns.
🔬 Verification: Ran `./gradlew :app:assembleStandardDebug` and `./gradlew :app:testStandardDebugUnitTest`. Verified no regressions and no em dashes were used in the changes.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@LeanBitLab
LeanBitLab merged commit d748f69 into main Oct 9, 2026
1 check passed
@LeanBitLab
LeanBitLab deleted the bolt-spellchecker-regex-optimization-3917702699552839353 branch October 9, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant