Repository navigation
feat(native-libs): add Servo rule and icon - #1411
Open
AnmiTaliDev wants to merge 1 commit into
Open
AnmiTaliDev wants to merge 1 commit into
AnmiTaliDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1369
Merge order
This PR is part of a series of rule PRs, each branched from
v4. Matcher IDs and icon indexes were allocated across the whole series in the order the PRs were opened, so they do not collide. Please merge the series in that order, oldest first.The order matters only for PRs that add new icons. Icon indexes are append-only and never reused, so the react-native-teleport PR must be merged before the Servo PR. If the react-native-teleport PR is closed without merging, the Servo icon index should be shifted down by one before the Servo PR is merged. The other PRs can be merged in any order, since skipped matcher IDs leave only a harmless gap.