Skip to content

Fix mpi io data leak #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thierrydaoud wants to merge 4 commits into
base: master
Choose a base branch
from
+0 −50
Open

Fix mpi io data leak #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71646d0
Remove the leaked MPI_IO_DATA scratch allocations
thierrydaoud Oct 27, 2026
ecc5f16
Merge branch 'MFlowCode:master' into fix-mpi-io-data-leak
thierrydaoud Oct 27, 2026
74ca04a
Merge branch 'master' into fix-mpi-io-data-leak
thierrydaoud Oct 28, 2026
8fdf800
Remove the leaked MPI_IO_IB_DATA scratch allocation
sbryngelson Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/post_process/m_global_parameters.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,23 +457,6 @@ contains
allocate (MPI_IO_DATA%view(1:sys_size))
allocate (MPI_IO_DATA%var(1:sys_size))
end if

do i = 1, sys_size
if (down_sample) then
allocate (MPI_IO_DATA%var(i)%sf(-1:m + 1,-1:n + 1,-1:p + 1))
else
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
end if
MPI_IO_DATA%var(i)%sf => null()
end do
if (qbmm .and. .not. polytropic) then
do i = sys_size + 1, sys_size + 2*nb*nnode
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
MPI_IO_DATA%var(i)%sf => null()
end do
end if

if (ib) allocate (MPI_IO_IB_DATA%var%sf(0:m,0:n,0:p))
#endif

! Size of the ghost zone layer is non-zero only when post-processing the raw simulation data of a parallel multidimensional
Expand Down
13 changes: 0 additions & 13 deletions src/pre_process/m_global_parameters.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,19 +562,6 @@ contains
allocate (MPI_IO_DATA%view(1:sys_size))
allocate (MPI_IO_DATA%var(1:sys_size))
end if

if (.not. down_sample) then
do i = 1, sys_size
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
MPI_IO_DATA%var(i)%sf => null()
end do
end if
if (qbmm .and. .not. polytropic) then
do i = sys_size + 1, sys_size + 2*nb*nnode
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
MPI_IO_DATA%var(i)%sf => null()
end do
end if
#endif

! Allocating grid variables for the x-direction
Expand Down
20 changes: 0 additions & 20 deletions src/simulation/m_global_parameters.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,24 +902,6 @@ contains
allocate (MPI_IO_DATA%var(1:sys_size))
end if

if (.not. down_sample) then
do i = 1, sys_size
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
MPI_IO_DATA%var(i)%sf => null()
end do
end if
if (bubbles_euler .and. qbmm .and. .not. polytropic) then
do i = sys_size + 1, sys_size + 2*nb*nnode
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
MPI_IO_DATA%var(i)%sf => null()
end do
else if (bubbles_lagrange) then
do i = 1, sys_size + 1
allocate (MPI_IO_DATA%var(i)%sf(0:m,0:n,0:p))
MPI_IO_DATA%var(i)%sf => null()
end do
end if

! Configure WENO averaging flag (arithmetic mean vs. unaltered values)
wa_flg = 0._wp; if (weno_avg) wa_flg = 1._wp
$:GPU_UPDATE(device='[wa_flg]')
Expand All @@ -929,8 +911,6 @@ contains
wenojs = .not. (mapped_weno .or. wenoz .or. teno)
#:endif

if (ib) allocate (MPI_IO_IB_DATA%var%sf(0:m,0:n,0:p))

if (hypoelasticity .or. mhd .or. probe_wrt .or. ib .or. bubbles_lagrange) then
fd_number = max(1, fd_order/2)
end if
Expand Down
Loading