Skip to content

Disable interpolation when reading the connection service file #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spicysharkco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable interpolation when reading the connection service file #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asyncpg/connect_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ def _parse_connect_dsn_and_args(*, dsn, host, port, user,
server_settings = {**query, **server_settings}

if connection_service_file is not None and service is not None:
pg_service = configparser.ConfigParser()
pg_service = configparser.ConfigParser(interpolation=None)
pg_service.read(connection_service_file)
if service in pg_service.sections():
service_params = pg_service[service]
Expand Down
4 changes: 2 additions & 2 deletions tests/test_connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@ def test_connect_connection_service_file(self):
host=somehost
database=test_dbname
user=admin
password=test_password
password=test%password
target_session_attrs=primary
krbsrvname=fakekrbsrvname
gsslib=sspi
Expand Down Expand Up @@ -1322,7 +1322,7 @@ def test_connect_connection_service_file(self):
[('somehost', 5433)],
{
'user': 'admin',
'password': 'test_password',
'password': 'test%password',
'database': 'test_dbname',
'target_session_attrs': 'primary',
'krbsrvname': 'fakekrbsrvname',
Expand Down