Skip to content

Guard Server.close/_unref when constructed with loop=None #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eryx-Z wants to merge 1 commit into from
Closed

Guard Server.close/_unref when constructed with loop=None #780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions uvloop/server.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ cdef class Server:
self._loop._servers.add(self)

cdef _unref(self):
# Server(None) is constructible from Python; guard before touching _loop.
if self._loop is None:
return
self._loop._servers.discard(self)

# Public API
Expand Down Expand Up @@ -77,6 +80,9 @@ cdef class Server:
def close(self):
cdef list servers

if self._loop is None:
return

if self._servers is None:
return

Expand Down
Loading