Repository navigation
Conversation
…der, even KPI tiles
- AWS, GCP and Cloudflare pass their resource tabs to dashboardPage's tabs slot, so they sit right
under the header like every other tabbed page (the body no longer adds ~40px above them).
- GCP: the route and lab share titleRow (time range, Reload); the projects strip no longer
collapses to 2px once the tabs left the body. The lab header shows its 12h span as a preset.
- KPI captions fit one line ("worst signal per zone" / "per service"), so tile heights match.
- Labs with a floating switcher pad their scroll area so the bar never covers the last row.
Maple review🟢 Confidence 9/10 · safe to merge Design pass 8 moves the AWS, Cloudflare and GCP view tabs into the page header's
What was checked
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maple review🟢 Confidence 9/10 · safe to merge Moves the AWS, GCP and Cloudflare view tabs into
What was checked
|
Design pass 8, stacked on #1829 (pass 7). Two independent agents checked it blind: one scored a rubric, the other hunted regressions and found none. Icons and data colours are untouched.
Judges
Changes
Provider tabs under the header. AWS, GCP and Cloudflare now pass their resource tabs to
dashboardPage'stabsslot, so they sit right under the header like every other tabbed page. The body no longer adds about 40px above them.GCP header. The route and the lab share
titleRow(time range and Reload). With the tabs out of the body, the projects strip had collapsed to 2px on the real route too; it is wrapped and fixed. The lab header shows its 12h fixture span as a preset, as the route's default does.Even KPI tiles. Captions fit one line ("worst signal per zone", "worst signal per service"), so the tile heights match.
Labs: a floating lab switcher no longer covers the last row; the scroll area pads for it.
A worker also added a click handler to the AWS tabs to keep the lab in place. That would have blocked Cmd-click on the real AWS page, so it was reverted before this PR.
Verification
bun run --cwd apps/web typecheckpasses, andoxlintis clean.🤖 Generated with Claude Code