Repository navigation
feat(web): design pass 10: aligned infra tables, readable picker, Alerts fits the viewport - #1832
Merged
Merged
Conversation
# Conflicts: # apps/web/src/page/infra-integrations/gcp/list/view-tables.ts
…rts fits the viewport - GCP: request counts drop a trailing .0 (880K, not 880.0K; GCP-only, the shared formatter's ticks keep it); volume headers sit over their right-aligned numbers; the picker reads "All 3 projects". - AWS: percentages right-aligned in a fixed slot; the name column caps at 480px and the CPU trend sparkline takes the rest of the row. - Alerts lab frame is fluid (it was a fixed 1200px wider than the 1152px column, clipping New rule and the Blind spots actions); the Blind spots heading no longer wraps at 1280.
Maple review🟢 Confidence 10/10 · safe to merge ui pass 10
What was checked
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design pass 10, the last in the stack. It sits on #1831 (pass 9). Two independent agents checked it blind: one scored a rubric, the other hunted regressions and found none. The rubric judge says the loop can stop; what remains is polish-level (8-20px edge alignments, a duration format). Icons and data colours are untouched.
Judges (this pass)
Final sweep: the original build vs now
A separate judge compared 23 screens from before the first design PR (#1814) with the current build. It found no regressions against the original.
Changes in this pass
Verification
bun run --cwd apps/web typecheckpasses, andoxlintis clean.Left for a decision (not in this stack)
clickhouse_settings_unavailableon query routes).🤖 Generated with Claude Code