Skip to content

feat(web): design pass 10: aligned infra tables, readable picker, Alerts fits the viewport - #1832

Merged
Makisuo merged 6 commits into
ui-pass-9from
ui-pass-10
Oct 25, 2026
Merged

Makisuo merged 6 commits into
ui-pass-9from
ui-pass-10

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Design pass 10, the last in the stack. It sits on #1831 (pass 9). Two independent agents checked it blind: one scored a rubric, the other hunted regressions and found none. The rubric judge says the loop can stop; what remains is polish-level (8-20px edge alignments, a duration format). Icons and data colours are untouched.

Judges (this pass)

Category Before After
Typography 7.5 8.0
Hierarchy 8.0 8.5
Spacing & density 6.5 8.5
Color & contrast 8.0 8.0
Iconography 8.0 8.0
Consistency & polish 6.5 8.5
Clarity 7.0 8.5
Overall 7.4 8.3

Final sweep: the original build vs now

A separate judge compared 23 screens from before the first design PR (#1814) with the current build. It found no regressions against the original.

Category Original Now
Typography 6.0 7.5
Hierarchy 5.0 7.5
Spacing & density 6.0 7.0
Color & contrast 6.5 7.5
Iconography 7.0 7.5
Consistency & polish 5.5 7.5
Clarity 5.0 7.5
Overall 5.9 7.4
Original Now

Changes in this pass

  • GCP: request counts drop a trailing ".0" (880K, not 880.0K). This is GCP-only: the shared formatter feeds chart ticks across ~179 files, where ".0" stays on purpose. Volume headers sit over their right-aligned numbers, and the picker reads "All 3 projects".
  • AWS: percentages are right-aligned in a fixed slot. The name column caps at 480px, and the CPU trend sparkline takes the rest of the row.
  • Alerts: the lab frame was a fixed 1200px, wider than the 1152px column, which clipped New rule and the Blind spots actions; it is now fluid. In the real hub, the "Blind spots" heading no longer wraps at 1280.
Before After

Verification

  • bun run --cwd apps/web typecheck passes, and oxlint is clean.
  • Targeted Vitest: 263 tests in infra integrations, alerts and labs.

Left for a decision (not in this stack)

  • Data pages say "couldn't load or save … data connection settings". Fixing that properly means changing the public v2 error contract (clickhouse_settings_unavailable on query routes).
  • With Infrastructure expanded on a 900px screen, the sidebar pushes Triage (Errors, Alerts, Code Review) below the fold. The options are auto-collapse or a scrolling footer.

🤖 Generated with Claude Code

# Conflicts:
#	apps/web/src/page/infra-integrations/gcp/list/view-tables.ts
…rts fits the viewport

- GCP: request counts drop a trailing .0 (880K, not 880.0K; GCP-only, the shared formatter's ticks
  keep it); volume headers sit over their right-aligned numbers; the picker reads "All 3 projects".
- AWS: percentages right-aligned in a fixed slot; the name column caps at 480px and the CPU trend
  sparkline takes the rest of the row.
- Alerts lab frame is fluid (it was a fixed 1200px wider than the 1152px column, clipping New rule
  and the Blind spots actions); the Blind spots heading no longer wraps at 1280.
@maple-review-bot

maple-review-bot Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 10/10 · safe to merge
Presentation-only class and formatter changes; every cross-file dependency (FRAME_WIDTH, heroFieldChipParts, columnHead) was checked at the head.
no findings · tests not needed · risk low

ui pass 10

  • FRAME_CLASS replaces the fixed FRAME_WIDTH in the alerts lab
  • heroFieldChipParts drops the chip label when it is empty; the GCP project picker shows the name alone
  • volumeHead right-aligns GCP volume-column headers over the counts; formatVolume drops a trailing .0
  • AWS tables: name column capped at 480px, CPU trend takes the slack, percent figures get a fixed 40px slot
What was checked
  • FRAME_WIDTH had no other importer (grep at head finds only FRAME_CLASS)
  • formatNumber yields .0K/.0M suffixes (packages/domain/src/format.ts:37), so the formatVolume regex matches
  • volumeHead reuses columnHead's class string ordering, so hidden md:flex still hides under md via cn

c194cff · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Makisuo Makisuo changed the title ui pass 10 feat(web): design pass 10: aligned infra tables, readable picker, Alerts fits the viewport Oct 25, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@Makisuo
Makisuo added this pull request to stack #1834 October 25, 2026 16:43
@Makisuo
Makisuo merged commit 1aaac7a into main Oct 25, 2026
22 of 23 checks passed
@Makisuo
Makisuo deleted the ui-pass-10 branch October 25, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant