Repository navigation
Conversation
…ates (#360 #241 #246 #169) Known answers for QUAL004 on DS_ Data grid 2 datasources and TEST_ helpers, CUSTOM002 on TEST_/GET_/PRS_/STUB_, and QUAL002 on MDL089 types (per-kind options), with upstream drafts. lint-backlog Batch 7 adds the four missing #169 candidates; the inbox file is promoted and deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
…swer (#372 review) The opt-out story never edits or deletes a .star file. Two sanctioned options remain: `enabled: false` recorded in PROJECT.md, and baseline-with-reason; upstream draft kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
MendixMau
pushed a commit
that referenced
this pull request
Oct 14, 2026
…and the #169 rule candidates (#360, #241, #246, #169) Review: independent review MERGE-AFTER-FIX — QUAL002 option names and QUAL004/CUSTOM002 advice verified against captured v0.24/v0.26 rule files; one option told users to edit VALID_PREFIXES in a stock .star (violates the one opt-out story) → removed in 5be2e41; confirmation MERGE. Inbox file fully promoted before deletion. Baseline unchanged. Closes #360 #241 #246 #169 (workarounds + upstream drafts; #169 rows added). Conflict: bug-logs/mxcli-bugs.md — both sides appended a BUG-DRAFT entry at the end; kept both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Merged
5 of 7 tasks
MendixMau
added a commit
that referenced
this pull request
Oct 15, 2026
…journey controls, fixes) (#385) Lands #340 #363 #362 #355 #370 #368 #364 #365 #366 #372 #367 #371 #376 #369 #373 #377 #378 #380. Review: each constituent PR independently reviewed by a fresh agent that did not write it; merged into integration/2026-10-15 only on a MERGE verdict with green CI (per-PR Review lines in the integration merge commits). After-fix rounds: #373 (env-var cap, rename/skip-loops freshness), #377 (inline URI fallback), #378 (full-pack double count, slice content). Stub diet (#369/#378/#380) behaviour A/B, 5 reps x 2 drafting tasks + 5 retrieval probes x 3 reps: trimmed context no worse than master on every scored metric (planted STOP refused 20/20, parse failures page 2/5 vs 3/5, probes 15/15); mdl Stage 5 56,236 -> 30,647 words, baseline 75,028 -> 73,233. Full suites on c9bc073: run-tests 33/0, wave2 111 fixtures 0 failing. Field evidence: none yet for the instruments (#355 warn-only, #373/#377 read-only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Owner
Author
|
Landed on master in #385 (squash Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #360, #241, #246, #169.
Dispositions
DS_flows used only as a Data grid 2 datasourcedescribe page, then baseline it with a reason. Never rename the flow or add a fake caller.BUG-DRAFT-qual004-dg2-datasource+pending-github-issues/qual004-dg2-datasource-ref.md.TEST_/GET_/PRS_/STUB_rules: CUSTOM002: enabled: falserecorded inPROJECT.md, or baseline with a reason. QUAL004 onTEST_: baseline with a reason. QUAL004 has no option, and it stays on because the coherence pass runs it. No.starfile is edited. Upstream draftlint-naming-prefixes-as-options.mdasks forget_option()on both prefix lists and fortests/*.test.mdlto count as callers.check_import_mappings,check_published_rest_services,check_java_actions,check_java_action_params. Themissing_documentation.starthatmxcli initwrites in v0.24.0–v0.26.0 reads them withget_option. Upstream draftqual002-skip-mdl089-types.md.process/lint-backlog.mdBatch 7, rows 51–54. The page-button refresh candidate was already row 7. Rows 53 and 54 are blocked on the same catalog fields as rows 36 and 12. The 2026-09-29 inbox file is promoted and deleted in the same commit. No upstream draft until a probe shows which field is missing.Direct lane
What changed and why (one paragraph):
skills/lint-that-actually-runs.mdgets a new section, "Stock rules against the toolkit's own conventions". It is a four-row table: the finding, why it is not a defect, and what to do today. Without it, agents "fix" these findings by renaming working flows, adding fake callers, or writing doc comments that MDL089 moves onto the next microflow.skills/process-coherence-pass.mdgets a matching warning: neither QUAL004 kind is an orphan to delete, because the rule's own suggestion is "Remove if unused".bug-logs/mxcli-bugs.mdgets a newBUG-DRAFT-qual004-dg2-datasourceentry, and its published-REST section, item 4, now also names the QUAL002 options. There are three new upstream drafts inbug-logs/pending-github-issues/. One finding needs reproduction upstream. Theorphaned_elements.starthat mxcli v0.24.0+ writes already countsdatasourcerefs, yet #360 saw the false positive on v0.26.0. So the gap is probably in the catalog ref for a pluggable widget's datasource, not in the rule. The draft is marked "reduce to a blank app first". No Starlark rule was changed.Word cost: both edited skills are loaded on demand, so the baseline stays at 75,028 words (budget 80,000).
Field evidence: none yet for the workarounds. The QUAL002 option names and the QUAL004/CUSTOM002 prefix constants were read from the rule files
mxcli initv0.24.0, v0.25.0 and v0.26.0 write. They have not been field-run, and the skill says so. Issue evidence: #360 (connector app, v0.26.0,QUAL004 (+1)ratchet failure), #241 (173 of 759 findings), #246 (45 QUAL002 findings, MDL089 output), #169 (two-arm build comparison).CHANGELOG.mdline appended, crediting @joshuamoesa ([learning] QUAL004 "not called from anywhere" fires on DS_ microflows that are only referenced as a page/grid datasource — lint ratchet then fails a correct script #360) and @MendixMau ([bug] CUSTOM002 and QUAL004 flag the toolkit's own TEST_/GET_/PRS_ conventions: 173 of 759 findings on a toolkit-built project #241, [bug] QUAL002 asks for documentation MDL cannot store (published REST services, import mappings): MDL089 #246, [idea] Lint rules for modelling errors that hit both arms (picker XPath vs entity access, refreshInClient, uncommitted change, empty-value functions, CE2729) #169)## BUG-DRAFT-<slug>:Review
The review verdict was MERGE-AFTER-FIX. Addressed in 5be2e41:
VALID_PREFIXESin the project copy" option. It is gone from the CUSTOM002 row inlint-that-actually-runs.md, the [bug] CUSTOM002 and QUAL004 flag the toolkit's own TEST_/GET_/PRS_ conventions: 173 of 759 findings on a toolkit-built project #241 row inlint-backlog.mdand the CHANGELOG line, because the toolkit's opt-out story never edits or deletes a.starfile.enabled: falserecorded inPROJECT.md, and baseline-with-reason.🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw