Repository navigation
process: mandatory five-row Impact block in every PR and review - #388
Merged
Merged
Conversation
Every Direct-lane PR and every review fills Process, Dependencies, Context cost, Behaviour and Runtime. Context cost is pasted from bin/render-routing.sh --check on base and head. RELEASE-PROCESS.md §4a holds the reviewer rule, the A/B requirement tiers and a bad/good example; CONTRIBUTING.md's reviewer list points there. No CI check: check-pr-discipline.sh reads the git diff, not the PR body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
…ile, docs read by agents are not n/a Independent review of #388: MERGE with four wording fixes, applied here. - Context cost may be "none: no routed or always-loaded file touched"; paste render-routing output only when a routed file changes. - Behaviour: process docs and templates read by review agents are agent-read text -> NOT RUN with a reason, never n/a; n/a is for scripts only. - CONTRIBUTING: the Impact check is its own numbered merge criterion. - Template says "every Direct-lane PR", matching the CHANGELOG line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
…ot require the A/B Applying the block to 11 open PRs marked #273 and #346 "A/B REQUIRED" only because render-routing added an on-demand row to agent stubs, with Context cost 0. Say so: that case is NOT RUN with the reason, not required. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
MendixMau
pushed a commit
that referenced
this pull request
Oct 15, 2026
Brings in #385, #388, #389. Clean merge: exec.sh (STOP-row scan, #349), skills/learned-mdl-preflight.md and CHANGELOG.md auto-merged with both sides kept; render-routing --check passes without a re-render. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Merged
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane
What changed and why (one paragraph): The maintainer asked for every PR review to state what a change costs. Tonight three PRs were reviewed without anyone stating their process cost: #375 added a human step per re-baseline and #384 adds 1–11 s per exec, and both were found only by chance. This PR adds a five-row Impact block (Process, Dependencies, Context cost, Behaviour, Runtime) to the Direct lane of the PR template.
docs/RELEASE-PROCESS.mdgets a new §4a: the reviewer confirms each of the five rows against the diff, a missing or estimated Context cost row is a review finding, the Behaviour A/B tiers are spelled out (required / recommended / n/a), and there is a bad/good example row.CONTRIBUTING.md's reviewer checklist points to §4a. No CI check was added, becausebin/check-pr-discipline.shreads the git diff and not the PR body.Field evidence: process change, not an instrument. The trigger is the 2026-10-15 review batch: #375 and #384, where the costs were found by chance.
CHANGELOG.mdline appended, crediting the maintainer requestImpact
render-routing.sh --checkon base and head) and +1 reviewer step (confirm 5 rows). Nothing new blocks in CI; the rule is enforced by review. No new stage artifacts._common.sh,exec.shorskill-routing.tsv. Only.github/PULL_REQUEST_TEMPLATE.md,docs/RELEASE-PROCESS.md,CONTRIBUTING.mdandCHANGELOG.md. Ordering: any open PR that edits CHANGELOG## Unreleasedor RELEASE-PROCESS §4/§5 may conflict trivially. No new tools or platform assumptions. No new artifact reads.bin/render-routing.sh --checkgives identical output on base868b3cband head: baseline 73,522 words (budget 80,000); stage 5 per role mdl 30,185, review 30,889, gate 22,354, test 21,296. None of the edited files are routed.render-routing.sh --checkthe author now runs takes about 12 s (measured: 12.4 s real).Checks run on head:
bin/render-routing.sh --check(in sync, baseline 73,522 / 80,000),bin/check-scripts.sh(114/114 shell, 22/22 Node),bin/check-portability.sh(clean, 248 files),LEAKGUARD_ALLOW_NO_DENYLIST=1 bin/check-no-client-data.sh(clean, 987 files; name check skipped because there is no denylist),bin/check-pr-discipline.sh(clean).🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Generated by Claude Code