Repository navigation
fix(exec): per-step seconds in the run summary and BUILD-LOG, gate seconds kept on a failed gate (409a) - #413
Merged
Merged
Conversation
…conds kept on a failed gate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MendixMau
force-pushed
the
feat/exec-step-timing
branch
from
October 16, 2026 02:31
8bf1007 to
f118bb0
Compare
This was referenced Oct 16, 2026
Merged
Merged
MendixMau
added a commit
that referenced
this pull request
Oct 16, 2026
…ection gaps closed (409b) (#416) Independent review: APPROVE. # Review #416, round 2 (delta): affected-tests, advisory Reviewed 2026-10-16 at head `8dc6eca2` (previous review `b91faaf6`, see 416.md). Detached worktree `/tmp/rv-416b`, read only, removed after. No GitHub comment. The delta is one fix commit plus a merge of origin/master. The merge brings in #407 (lint-gate); against origin/master the PR's own file list is unchanged. ## The four points | # | Point | Status | Evidence | |---|---|---|---| | 1 | Unmapped count counts every `journeys/` file not named `<Module>.journey.json` | **Fixed** | A file in `journeys/` now counts as mapped only when its stem is one identifier (`*[!A-Za-z0-9_]*` falls through to the content check). The new test file `journeys/Shop.admin.journey.json` names nothing, and the row expects `2 of 6`. Mutation: with the old blanket `continue` put back, `A unmapped` fails (62/1). Not done, and optional: checking the stem against the modules the model knows. | | 2 | NOT MEASURED rows for module role, user role, constant | **Fixed** | exec.sh emits `userrole` for CREATE/ALTER/DROP USER ROLE. affected-tests adds `role`, `userrole` and `constant` to the data set. A user role is kept out of the module list and gets its own "access change, no owning module" text. Test J covers all three, plus ALTER and DROP, and checks that `Admin` is never read as a module. Minor, not blocking: `create or modify user role Admin (...)` still gives `unmapped -` (the USER check reads token 2 only). This matters only if that form is valid MDL. | | 3 | Catalog freshness | **Fixed (evidence plus a guard test)** | `CAPTURE-FRESHNESS.txt` on v0.26.0: 4 callers, then an exec adds `ZZ_Probe_Caller`, then the catalog rebuilds (21 flows, 507 refs) and the call lists 5, the new one at depth 1. The capture is condensed, not a byte-verbatim paste. Test K uses a stub whose output follows the .mpr: K1 lacks the new caller and K2 lists it. Mutation: a stub that ignores the .mpr (a stale catalog) makes `K2 stale` fail (62/1). K also checks that the script keeps no cache file. Limit: an offline test cannot prove that mxcli's own catalog is fresh. The capture covers that, and the header now states it. | | 4 | Text fixes | **Fixed** | Header timing is now 19 s / 3 s, matching the PR. Step order is 1 to 6. The PR body's size line says "over" with the reason (541 lines, script and tests ship together). CHANGELOG entry updated. Cosmetic: header line 42 now runs past the wrap width. | ## Still advisory - affected-tests exits 0 (2 on usage) and runs no test. The `run` rows are text. - exec.sh delta is a comment and one awk line inside `mxtk_subjects` (the `--subjects` path only). Exec exit codes are unchanged. The hint line is untouched. ## Checks - `test-affected-tests.sh` 63/0, `test-exec-subjects.sh` 6/0 (`/bin/bash` 3.2). - `check-pr-discipline.sh origin/master`: clean. - Side note, not this PR: running the uninstalled script from `/tmp/rv-416b/project-bin` on a scratch dir with no project resolved `PROJECT_ROOT` through `_common.sh` and walked a large tree with `find` (killed). This is installed-layout behaviour that predates this delta. ## Verdict **APPROVE** Land after #413. The CHANGELOG line may need a rebase.
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane
What changed and why (one paragraph):
exec.shnow prints and logs per-step seconds:steps: guards Ns check Ns snapshot Ns baseline Ns exec Ns gate Ns lint Ns score Nsin the run summary and at the end of the BUILD-LOG detail cell. Before this, a row carried only the run total, so nobody could say where a 28 to 41 s exec went. The gate mark is taken straight after the mxbuild run, before any pass or fail branch. In the first version (in #409)gatewas marked only insidelog_applied, so every rolled-back or failed-gate row lost its gate seconds; in the lab those are 47 of 238 rows, the costliest 20%. Split out of draft #409 (first of three) so that both arms of the test-strategy A/B log the samesteps:cell.Impact
project-bin/exec.sh(marks only; no behaviour change). Parsers that read the BUILD-LOG detail: greppedbin/andproject-bin/, none reads the detail by position, and the new cell is last. No new artifact reads. Independent of the--subjectsPR (b); both prepend a CHANGELOG line, so the second to merge needs a trivial CHANGELOG rebase.date +%scalls per exec. Measured: one call takes 22.8 ms under bash 3.2, so about 0.2 s per exec, 0.5 to 0.7% of a 28 to 41 s exec.Field evidence: the per-step split and the failed-gate loss were measured on a five-app lab project (Mendix 11.15, mxcli v0.26.0, 238 BUILD-LOG rows).
tests/wave2/test-exec-step-times.sh7/0 on this branch, 4 pass and 3 fail on master'sexec.sh(summary steps line, BUILD-LOG steps cell, failed-gate row). It covers a passing and a gate-failing--patchrun. Existing:test-exec-change-class.sh21/0,test-exec-lock-watch.sh84/0,test-manifest-clean-checkout.sh1/0. Only macOS was run; Git Bash was not.CHANGELOG.mdline, credited🤖 Generated with Claude Code