Repository navigation
fix(process-map): migrate follow-ups from the #438 review - #453
Merged
Merged
Conversation
Check the top-level anchors key changed after the regex rewrite and fall back to re-writing the model otherwise; accept a string targets value; list unfilled entries of the current anchors file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three non-blocking regressions in the process-map migrate step, from the #438 re-review.
"anchors": "..."at any depth. After the rewrite the result is now parsed and the top-level key checked; if it did not change, the whole model is re-written with the key set. The output only says "only that key was changed" when that is true."targets": "P1-02"(a string) crashed migrate. A string is now a one-item list.Tests in tests/wave2/test-process-map-field.sh, one group per item (6 of the new checks fail without the fix). process-map tests, brd-report-process-map, check-portability and check-pr-discipline are clean.
🤖 Generated with Claude Code