[pskrunner14]

The license check treated every file under src/runtime/ggml/ as derived from parakeet.cpp, so new first-party files there (llama_log_shim.cpp from #47) failed unless they carried a third-party notice that does not apply. List the nine derived files from the initial release in DERIVED_FILES and drop the directory prefix.

Fixes #74.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: NVIDIA/NeMo-Speech.cpp
• Branch: fix/license-derived-files
• File: .coderabbit.yaml
• Commit: ca14db9
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 0a27af2d-a883-457c-a46b-843da6e9aa8e

Commits

Reviewing files that changed from the base of the PR and between 1a7e945 and ca14db9.

Files selected for processing: 1

• scripts/check_license_headers.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Updated license-header checks so only specifically listed derived files require the additional attribution block. Other files in the ggml directory are no longer expected to include it.

The license header checker now identifies derived ggml files with an explicit list. It adds and requires the parakeet.cpp attribution only for listed files.

Changes: License header checks

Layer / File(s)	Summary
Explicit derived-file matching scripts/check_license_headers.py	The checker replaces the directory-wide match with a list of nine derived files. Both expected-header generation and header validation use this list.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: Minimal · up to ca14d

No actionable merge-blocking risk remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: explicitly listing derived runtime files for the license check.
Description check		The description is directly related to the changeset. It explains the license-check failure, the explicit derived-file list, and the issue addressed.
Linked Issues check		Issue #74 requires the license check to stop requiring the parakeet.cpp notice for unrelated files such as src/runtime/ggml/llama_log_shim.cpp. The PR removes DERIVED_PREFIX and adds the nine inte…
Out of Scope Changes check		The whole-PR diff changes only scripts/check_license_headers.py. The change replaces directory-wide derived-file handling with an explicit file list. This directly supports issue #74 and does not ad…

Full details: Linked Issues check

Explanation

Issue #74 requires the license check to stop requiring the parakeet.cpp notice for unrelated files such as src/runtime/ggml/llama_log_shim.cpp. The PR removes DERIVED_PREFIX and adds the nine intended ggml files to DERIVED_FILES. expected_header and has_header now apply the derived notice only when the exact path is listed. The shim is not listed, so its NVIDIA-only header is accepted.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes only scripts/check_license_headers.py. The change replaces directory-wide derived-file handling with an explicit file list. This directly supports issue #74 and does not add unrelated behavior.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Replaces the blanket derived-file rule for src/runtime/ggml/ with nine explicit paths.

• The license checker ties derived notices to named files.

_{Reviews (1) · Last reviewed commit: "fix(license): list parakeet-derived runt..." · Reviewed by Greptile}