fix(exec): any_sender completion signatures for sequence with 3+ senders - #2223
Open
alwaysprince05 wants to merge 3 commits into
Open
fix(exec): any_sender completion signatures for sequence with 3+ senders#2223alwaysprince05 wants to merge 3 commits into
alwaysprince05 wants to merge 3 commits into
Conversation
When exec::sequence has 3+ senders, it recursively computes completion signatures by peeling off the first sender and querying the tail as a sub-sequence (__seq::__sndr). This tail holds child senders by const&. The get_completion_signatures discovery machinery passes the sender type un-decayed (as const any_sender&), but any_sender's constraint std::derived_from<Self, _interface_> fails because reference types are never derived_from anything. Fix by decaying Self before the derived_from check in _isender::_interface_::get_completion_signatures(). Fixes NVIDIA#2101
Collaborator
|
a |
… 3+ senders" This reverts commit 708187d.
When exec::sequence has 3+ senders, it recursively computes completion signatures by peeling off the first sender and querying the tail as a sub-sequence (__seq::__sndr). The nested sender types were passed by reference to get_completion_signatures, causing failures with any_sender whose get_completion_signatures requires a non-reference type. Fix by decaying sender types before passing to get_completion_signatures in __sndr::get_completion_signatures(). Fixes NVIDIA#2101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exec::sequence has 3+ senders, it recursively computes completion signatures by peeling off the first sender and querying the tail as a sub-sequence (__seq::__sndr). This tail holds child senders by const&. The get_completion_signatures discovery machinery passes the sender type un-decayed (as const any_sender&), but any_sender's constraint std::derived_from<Self, interface> fails because reference types are never derived_from anything.
Fix by decaying Self before the derived_from check in _isender::interface::get_completion_signatures().
Fixes #2101