[20.0][MIG] queue_job: Migration to 20.0 by dhongu · Pull Request #999 · OCA/queue

dhongu · 2026-09-28T16:42:06Z

Migration of queue_job to Odoo 20.0.

Main changes:

ir.model.access + ir.rule → ir.access
registry.clear_cache → transaction.invalidate_ormcache
controller: use odoo.sql_db.PG_CONCURRENCY_EXCEPTIONS_TO_RETRY (odoo.service.model was removed); env.clear() → env.transaction.clear()
jobrunner: odoo.modules.db.list_dbs (odoo.service.db was removed)
fields: _setup_attrs → _setup_attrs__; tools.ormcache → api.ormcache
JS: job_direct_graph widget ported to Owl 3 (useProps, signal ref)
views: remaining_days widget → relative_date; stat button icon
tests: odoo.http.Request → odoo.http.requestlib.Request
lint fixes required by the 20.0 template (ruff 0.16.8, pylint-odoo 10): a few small refactors, and # noqa: DTZ005 on datetime.now() because Odoo stores naive UTC datetimes

Tested locally on Odoo 20.0 with PostgreSQL 16: the module installs and all 54 queue_job tests pass. pre-commit run -a is clean.

This PR also includes the work prepared by @jaredkipe in #997 (co-authored).

test_queue_job and the other addons will follow in separate PRs.

Assisted-by: Claude Opus 5.5

oca-cla-bot · 2026-09-28T16:42:12Z

All commit authors signed the Contributor License Agreement.

Reyes4711-S73 · 2026-10-05T09:38:01Z

@dhongu Please, add commits history like https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-20.0

BhaveshHeliconia

Thanks @dhongu for working on this!

While testing, I found that clicking another job in the Dependencies tab raises an error because get_formview_action() was removed in Odoo 20.0.

Fix: build the form action directly in JS instead of asking the server, then pass it to this.action.doAction(). I tried this locally and the click opens the job correctly.

micheledic

Adding to this, you should preserve the full history.

micheledic · 2026-10-15T15:55:08Z

Suggested change

"get_record_default_action",

Odoo 19 renamed Field._setup_attrs to _setup_attrs__, so the override was no longer called and an unsupported base_type was silently accepted.

The failure is handled from a temporary cursor while the failed job's transaction still holds its locks: an on fail hook writing on the same records waited forever. Perform the job in a savepoint so that its locks are released when it fails.

odoo shell starts the server with stop=True and stops it right away, so the runner thread was started for nothing and its START_DELAY made every shell wait 5 seconds before the prompt. Core already skips its HTTP and cron threads when stop is set; the runner now follows the same rule.

dhongu · 2026-10-16T09:09:42Z

Thanks for the reviews, both points are addressed:

History: the branch is rebuilt following the 20.0 migration guide (git format-patch ... origin/20.0..origin/19.0 -- queue_job | git am -3 --keep). The 19.0 commits merged after the 20.0 branch was created are now included (JobSerialized base_type validation, on-fail hook deadlock, jobrunner in odoo shell), followed by a [IMP] pre-commit auto fixes commit and the [MIG] commit.
Dependencies tab: get_formview_action → get_record_default_action, as suggested by @micheledic. Thanks @BhaveshHeliconia for the report.

pre-commit run -a is clean and all 56 queue_job tests pass locally on Odoo 20.0.

BhaveshHeliconia

LGTM!

BhaveshHeliconia · 2026-10-16T12:15:16Z

You shouldn't add the AI agent as a co-author. It should be mentioned as assisted by AI according to the OCA AI policy: https://github.com/OCA/.github/blob/master/AI_POLICY.md

miguel-S73 · 2026-10-19T08:52:10Z

LGTM!

- ir.model.access + ir.rule -> ir.access - registry.clear_cache -> transaction.invalidate_ormcache - controller: use odoo.sql_db.PG_CONCURRENCY_EXCEPTIONS_TO_RETRY (odoo.service.model was removed); env.clear() -> env.transaction.clear() - jobrunner: odoo.modules.db.list_dbs (odoo.service.db was removed) - fields: _setup_attrs -> _setup_attrs__; tools.ormcache -> api.ormcache - JS: job_direct_graph widget ported to Owl 3 (useProps, signal ref); get_formview_action -> get_record_default_action (removed in 20.0) - views: remaining_days widget -> relative_date; stat button icon - tests: odoo.http.Request -> odoo.http.requestlib.Request - lint fixes required by the 20.0 template (ruff 0.16, pylint-odoo 10) Co-authored-by: Jared Kipe <jared@hibou.io> Assisted-by: Claude Opus 5.5

dhongu · 2026-10-19T11:36:41Z

Thanks @BhaveshHeliconia, good point. The migration commit now uses an Assisted-by: Claude Opus 5.5 trailer instead of Co-authored-by, in line with the OCA AI policy, and the PR description is updated accordingly. Only the commit message changed; the code is identical.

alan196

Functional Review LGTM 👍

ristecona · 2026-10-22T09:00:07Z

Tested on Odoo 20.0 (OCB at 1ab6b915 with the Enterprise addons) at the head of this branch (33c10a8). queue_job installs on a clean database and all 56 tests pass.

One note for completeness: when the website module is installed in the same database, TestRunJobHttp.test_runjob_without_updating_default_env_leaves_uid_none fails with a 500. The server log shows KeyError: 'host_id' in website/models/ir_http.py (_generate_routing_rules), raised while the routing map is built for the first request of an HttpCase. It is not caused by this migration, and the test passes without website, which is how the CI runs.

I also used it for a health check that looks at stuck queue.job records (state, date_enqueued, date_started), and it behaves as on 19.0.

Tested with the help of Claude Code (AI assisted).

OCA-git-bot added mod:queue_job Module queue_job series:20.0 labels Sep 28, 2026

dhongu force-pushed the 20.0-mig-queue_job branch from b6649a8 to 6748713 Compare September 28, 2026 17:30

dhongu mentioned this pull request Sep 28, 2026

20.0 queue_job ready waiting branch #997

Closed

This was referenced Oct 12, 2026

[20.0][MIG] queue_job_cron_jobrunner: Migration to 20.0 #1008

Open

[20.0] queue_job and queue_job_cron_jobrunner: migration to 20.0 Jarsa/queue#3

Merged

BhaveshHeliconia suggested changes Oct 13, 2026

View reviewed changes

micheledic suggested changes Oct 15, 2026

View reviewed changes

thomas-tankengine mentioned this pull request Oct 16, 2026

[20.0][MIG] queue_job_cron: Migration to 20.0 #1012

Open

HoloborodkoBohdan and others added 7 commits October 16, 2026 11:40

[FIX] queue_job: validate JobSerialized base_type again

9793aad

Odoo 19 renamed Field._setup_attrs to _setup_attrs__, so the override was no longer called and an unsupported base_type was silently accepted.

[BOT] post-merge updates

3d75b4c

[BOT] post-merge updates

9d6e1e0

[BOT] post-merge updates

78b1bda

[IMP] queue_job: pre-commit auto fixes

52357dc

dhongu force-pushed the 20.0-mig-queue_job branch from 6748713 to 2b08ccd Compare October 16, 2026 09:09

BhaveshHeliconia approved these changes Oct 16, 2026

View reviewed changes

miguel-S73 approved these changes Oct 19, 2026

View reviewed changes

dhongu force-pushed the 20.0-mig-queue_job branch from 2b08ccd to 33c10a8 Compare October 19, 2026 11:29

alan196 approved these changes Oct 19, 2026

View reviewed changes

HviorForgeFlow mentioned this pull request Oct 21, 2026

[20.0][MIG] edi_queue_oca: Migration to 20.0 OCA/edi-framework#378

Open

2 tasks

Navigation Menu

Repository navigation

[20.0][MIG] queue_job: Migration to 20.0 - #999

[20.0][MIG] queue_job: Migration to 20.0#999
dhongu wants to merge 8 commits into
OCA:20.0from
dhongu:20.0-mig-queue_job

dhongu commented Sep 28, 2026 •

edited

Loading

Uh oh!

oca-cla-bot Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

Reyes4711-S73 commented Oct 5, 2026

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

micheledic left a comment

Uh oh!

micheledic Oct 15, 2026

Uh oh!

dhongu commented Oct 16, 2026

Uh oh!

BhaveshHeliconia left a comment

Uh oh!

BhaveshHeliconia commented Oct 16, 2026

Uh oh!

miguel-S73 commented Oct 19, 2026

Uh oh!

dhongu commented Oct 19, 2026

Uh oh!

alan196 left a comment

Uh oh!

ristecona commented Oct 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

dhongu commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oca-cla-bot Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reyes4711-S73 commented Oct 5, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

micheledic left a comment

Choose a reason for hiding this comment

Uh oh!

micheledic Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

dhongu commented Oct 16, 2026

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Oct 16, 2026

Uh oh!

miguel-S73 commented Oct 19, 2026

Uh oh!

dhongu commented Oct 19, 2026

Uh oh!

alan196 left a comment

Choose a reason for hiding this comment

Uh oh!

ristecona commented Oct 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

dhongu commented Sep 28, 2026 •

edited

Loading

oca-cla-bot Bot commented Sep 28, 2026 •

edited

Loading