Repository navigation
New version of form-processing script for updated schema - #191
Conversation
|
Now adresses #186 |
There was a problem hiding this comment.
Github action generate_html fails:
- when running
uv run yaml_to_html.py, becauseproblems.yamlcontains'?'where input should be'yes', 'no', 'some' or 'unknown'. - Happens at least for:
suite_morepoandsuite_cec2015_dmoo - Maybe these are ouput of the form processing script? Otherwise we can just change them to
unknownand that should fix it
Github action check_new_problems fails:
- it cannot find module
pydantic_yaml - Maybe the problem is that:
pydantic_yamlis inrequirements.txtbut not inutils/requirements.txt - When running with
uv run utils/validate_yaml.py problems.yaml(rather thanpython utils/validate_yaml.py problems.yamlas in the action), the action fails withImportError: cannot import name 'default_columns' from 'yaml_to_html'
Execution of formresponse_to_yaml.py fails:
- When run with
uv run formresponse_to_yaml.py, the errorNo such file or directory: 'responses_OPL.csv'comes up - Suggestion: Change the default file name to the correct one
- Suggestion 2: Add instructions in a README (maybe in
utils? Perhaps this entire script should go there?) on how thi should be executed. - When run with
uv run formresponse_to_yaml.py --csv OPL_form.csvexecution fails with 44 validation errors -- Seemingly about execution times not being in the format expected by pydantic (but maybe not limited to that)
|
Merging main back in did no resolve any of these issues. |
These are not from the processing, but I did change them to unknown anyway
I tried changing this to uv, but I think I overlooked something, will check this next week. The column naming this is fixed now
It seems I forgot to upload the readme last time, that is included now (should also fix the wrong default name for the csv). The validation errors remain an issue, I tried changing how the times are handled but either way I do it the validator complains: If I make it a string:
If I make it a set:
@olafmersmann Do you maybe know what I'm missing here? |
|
The workflow running |
I wanted to merge main back into this branch, to include the updated workflow. But there seem to be some painful conflicts on the @Dvermetten Can you confirm there are no new problems/implementations and/or changes to their attribute values in this PR? I.e.: All changes here are purely irrelevant ordering changes.
|
I don't see any new problems in this branch that aren't in main. There are some new form entries (from the other hackathon), but I think it is better to do those in a new PR after this one is merged |
Agreed on doing new problems in a separate PR. I now merged main back into this (using the YAML + HTML from main). This seems to have fixed most previously mentioned issues. @Dvermetten One issue remains/is visible now, as far as I can see:
|
|
@kvdblom I think this happens because of the change in schema between when these form-entries were first processed and now. It was happening here even when nothing was updated simply because of the loading and saving of the yaml itself. |
kvdblom
left a comment
There was a problem hiding this comment.
- One minor fix
- One decision we need to make
- Other than this it looks good (I don't think anything else weird happens)
| - authors: | ||
| - Carolin Mensendiek | ||
| - Henrik Zeipel | ||
| - "Oliver Ludger Preu\xDF" |
There was a problem hiding this comment.
We should decide whether this is what we want. To me it seems more natural to do the formatting of names 'symbols' in the conversion to HTML than in the YAML. But ultimately it is just a decision we need to make.
New (generated) script for converting the form responses (csv file) to the updated schema.