Repository navigation
Conversation
Changes to the rules registry, the guard runner and CODEOWNERS itself need review from a core developer other than the author. Deliberately narrow: pyproject.toml files and workflow files are not owned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The lint job installed whatever ruff was latest. Pin it to 0.15.22 (the newest version in the project locks), and add a root ruff.toml selecting ruff's current default rules so an upgrade cannot change which rules apply. ruff format output is unchanged across every src and tests directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The image smoke skipped PRs that only change policyengine-stage12-persistence, although the v2 Modal images mount it; add it to the path filter. Add libs/policyengine-fastapi to the PR test matrix and make test, so its tests run in CI like every other library. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agents must not merge with `gh pr merge --admin` or use GitHub's option to bypass rules, even with admin credentials; a blocked merge is reported to a human instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anth-volk
added this pull request to stack #755
October 12, 2026 19:29
This was referenced Oct 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #753
Same-Repository Draft PR Check
PolicyEngine/policyengine-sim-api, not a personal fork.Summary
Phase 0 of the rules workstream: make CI enforcement trustworthy before the rules registry (#752, kept as a draft until this merges). The API counterpart is PolicyEngine/policyengine-api#3887.
rules/,scripts/rules/,scripts/run_quality_guards.pyand CODEOWNERS itself, owned by@PolicyEngine/core-developers.pyproject.tomlfiles and workflow files are not owned, so dependency bots and everyday CI edits aren't blocked. The paths take effect once Add a rules registry that makes every enforced and unenforced rule visible #752 creates them.ruff==0.15.22, the newest version in the project locks. A rootruff.tomlselects ruff's current default rules explicitly. No behaviour change:ruff formatoutput is byte-identical before and after across everysrcandtestsdirectory, andruff checkreports the same 9 existing F401s. Stricter ruff, including fixing those F401s and addingruff checkto CI, comes in separate PRs right after the registry lands.libs/policyengine-stage12-persistence/**is added to thePR image smokepath filter. The v2 Modal images mount that library (src/modal/v2_app.py), so a Stage 12-only PR used to skip the smoke. Because this PR edits the workflow, the smoke also runs here.libs/policyengine-fastapiis added to the PR test matrix andmake test.github-prs.mdandAGENTS.mdnow say agents never bypass branch rules (for examplegh pr merge --admin), even with admin credentials. The tracking-issue andFixes #rules were already documented here.Step 0.1 is not in this PR. It's a ruleset change, applied separately after merge: a pull-request rule with code-owner review, plus required checks
Lintand everyTest (<project>)leg, including the newTest (libs/policyengine-fastapi).Quality guardsis added after #752 merges.Testing
libs/policyengine-fastapi:uv sync --extra test && uv run pytest tests/passes 14 tests, with 59% coverage against a required 30%.ruff@0.15.22 format --checkpasses on everysrcdirectory. The format diff is identical before and afterruff.tomlfor everysrcandtestsdirectory.changelog_entry.yamlparse as YAML.actionlintreports only a pre-existing shellcheck note on the format loop.pr-image-smoke.yml(test_modal_scripts.py) checks only secrets and step order, so it's unaffected by the added path.🤖 Generated with Claude Code