Repository navigation
Conversation
WpCliDiscovery builds commands through the discovery's instance pool instead of resolve(). An architecture test keeps the module, provider and generator aside, to the attributes, discovery, PSR logging and WP-CLI.
ogorzalka
force-pushed
the
refactor/wp-cli-decoupling
branch
from
October 12, 2026 16:06
b3472df to
dfa210d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of extracting
pollora/wp-cli(roadmap, medium term: "close to WordPress already; depends mostly on discovery"). Nothing moves yet.What changes
WpCliDiscoverybuilds command instances through the discovery's instance pool, keeping one per class, instead of a fallback callingresolve(). In a Pollora application the pool uses Laravel's container, as before; elsewherepollora/discovery's reflection autowiring.tests/Unit/WpCli/PackageBoundaryTest.php: the module may only use the attributes, discovery, PSR logging and WP-CLI.WpCliServiceProvider(console detection) andpollora:make:wp-clistay in the framework. The test fails on the previous code (also uses 'resolve').No behaviour change: in production the engine always gave the discovery its pool.
Checks
1881 tests, PHPStan 0, Rector clean. Independent of #464.