Skip to content

Remove BaseException Uses #7401

Closed
#8859
Closed
Remove BaseException Uses#7401
#8859
Assignees
AlexanderSaninericspod
Labels
enhancementNew feature or request

Description

@ericspod
ericspod
opened on Jan 18, 2024

Describe the bug
BaseException is being caught in places and it's not clear this should be done or is appropriate. Bugbear is not complaining about it as B036 as shown in #7397. Should these be replaced with just Exception? It's not documented anywhere if there's an explicit reason to not do this.

Activity

  1. KumoLiu
    added
    enhancementNew feature or request
    on Jan 22, 2024

  2. AlexanderSanin commented on May 18, 2026

    @AlexanderSanin
    AlexanderSanin
    on May 18, 2026
    Contributor

    Hi @ericspod , I've submitted a PR to address this issue: #8859. It replaces all 17 occurrences of except BaseException with except Exception across monai/ and tests/. Happy to adjust if needed.

  3. ericspod
    assigned
    ericspod
    and
    AlexanderSanin
    on May 19, 2026
  4. ericspod
    closed this as completedin #8859on May 19, 2026
  5. pull
    added a commit that references this issue on May 19, 2026

    Replace BaseException with Exception across codebase (Project-MONAI#8859

    286e905
  6. Rusheel86
    added a commit that references this issue on May 25, 2026

    Replace BaseException with Exception across codebase (Project-MONAI#8859

    70669c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions