[EHNANCEMENT] Better Performance For engines/utils.py

@ericspod

I‘m creating this so that we don’t forget about the enhancement proposal by @ericspod in #8747 (thank you Eric for the Suggestion!)

@benediktjohannes

Hi @benediktjohannes and @ericspod, I'd like to implement the suggestion from @ericspod in #8747.

My plan:

In PrepareBatchExtraInput.__call__ (monai/engines/utils.py), replace the args_ list + for loop with a direct generator expression passed to tuple(), and replace kwargs_.update({k: ...}) with a dict comprehension — exactly as @ericspod suggested in the resolved review comment on Slightly improve performance in engines/utils.py #8747.
Add/update the existing unit tests in tests/engines/test_utils.py to cover the refactored path.

This is a non-breaking refactor (semantically identical, slightly more efficient). Does this match what you had in mind?

enh(engines/utils): use tuple/dict comprehensions in PrepareBatchExtr…

@Zeesejo

Hi @Zeesejo I'm fine for you to go ahead, I should see the PR once it's ready.

Perfect, thank you!

Navigation Menu