Repository navigation
ci: CI, a load test and npm trusted publishing (OIDC); release 1.2.1 [PRV-7340] - #6
Merged
Merged
Conversation
…RV-7340] The package was published by hand and had no tests or CI. Add a load test (node:test; it needs loopback-datasource-juggler, which the host app provides, so it is a devDependency only), CI on Node 18 to 24 with zizmor, and publish.yml (OIDC trusted publishing) from the log4js-cloudwatch-appender template. repository/bugs/homepage point to PruvoNet (npm provenance needs a matching repository.url). files: ["index.js", "lib"] keeps the same 11 published files. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The package was published by hand from a laptop and had no tests or CI.
test/load.test.js,node:test): the package loads and exports a LoopBack connector (initialize). It fails if the export breaks (checked locally).loopback-datasource-juggler@^2.59.3as a devDependency only: the coderequires it but expects the host app to provide it (the monorepo uses the PruvoNet fork, 2.59.2). No change for consumers.ci.yml:npm ci+npm teston Node 18–24, plus theWorkflow security (zizmor)job.publish.yml,dependabot.yml,zizmor.yml: same aslog4js-cloudwatch-appender.package.json:repository/bugs/homepage→PruvoNet(npm provenance requiresrepository.urlto match; the old URL even namedloopback-component-flat-storage).files: ["index.js", "lib"]: same 11 files as1.2.0.enginesstays unset (no claim existed). Version1.2.1. No code change.Monorepo impact
None: the root catalog pins
loopback-component-flatstorage: 1.2.0exactly.After merge
PruvoNet/loopback-component-flatstorage/publish.yml/ no environment /npm publishticked. Publishing access → disallow tokens.publish.yml→ verify1.2.1with provenance.Ticket: PRV-7340.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.