Skip to content

Update template - #13

Draft
jnnr wants to merge 7 commits into
PyPSA:mainfrom
jnnr:feature-update-template-2
Draft

jnnr wants to merge 7 commits into
PyPSA:mainfrom
jnnr:feature-update-template-2

Conversation

@jnnr

@jnnr jnnr commented Oct 11, 2026 •

Copy link
Copy Markdown

Applies the latest template by running copier recopy.
Fixes #9.
@bobbyxng: this partially overlaps with #12, but should provide reference for solving issue #9 and adhering to the template.

Summary of changes in this pull request

  • Run copier recopy to adhere to latest data-module-template version and reconcile conflicts
  • Use data-module-template's config.schema.yaml for config validation, instead of pydantic models.
  • Tested importing into another workflow: works.

More detailled pydantic schema validation could be instead applied in the respective processing scripts. This should be addressed before making this draft a proper PR.

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@ekatef

ekatef commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Hello @jnnr, thanks for providing hand-ons on adhering with the template! I have tested your fix locally and confirm it's working.

After an initial scan, I think is it makes perfect sense to stick with your implementation as harmonised conventions are actually a decisive advantage of the modelblocks. So, it's crucial we'll learn to work with them and reviewing your implementation feels a great exercise for that.

I have started to review the PR (exploring in parallel the template in more details) and will try to provide some more meaningful feedback and questions in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to import module via github url

2 participants