Repository navigation
Conversation
Collaborator
|
Hello @jnnr, thanks for providing hand-ons on adhering with the template! I have tested your fix locally and confirm it's working. After an initial scan, I think is it makes perfect sense to stick with your implementation as harmonised conventions are actually a decisive advantage of the modelblocks. So, it's crucial we'll learn to work with them and reviewing your implementation feels a great exercise for that. I have started to review the PR (exploring in parallel the template in more details) and will try to provide some more meaningful feedback and questions in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the latest template by running copier recopy.
Fixes #9.
@bobbyxng: this partially overlaps with #12, but should provide reference for solving issue #9 and adhering to the template.
Summary of changes in this pull request
More detailled pydantic schema validation could be instead applied in the respective processing scripts. This should be addressed before making this draft a proper PR.
Reviewer checklist
pipdependencies in the module's environment files (workflow/envs/).pathvars(e.g.,<results>) in their inputs and outputs.pre-commit.citests pass.INTERFACE.yamlmentions all relevantpathvarsandwildcards.README.mddescribes how to use the module and has the necessary citations.