Repository navigation
fix: multiply constant or one-term expression by multi-term expression - #1076
Open
anveshachuri wants to merge 2 commits into
Open
anveshachuri wants to merge 2 commits into
anveshachuri wants to merge 2 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Collaborator
|
@claude why is there a performance warning for the sparse path? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1055.
I picked up this issue because multiplication behaved asymmetrically depending on the order of the operands: a constant or one-term expression could multiply a multi-term expression in one direction but fail in the other. This change fixes that inconsistency while preserving the existing restriction on multiplying two multi-term expressions.
I added tests covering both multiplication orders for constant and one-term expressions on dense and sparse backends, while verifying that multi-term × multi-term still raises
TypeError. The full test suite passes locally, excludingtest/remote, which requires theoetcextra.Checklist
AGENTS.md).doc.doc/release_notes.rstof the upcoming release is included.