Skip to content

Use auto-activate instead of the deprecated auto-activate-base - #109

Merged
mmcky merged 1 commit into
mainfrom
claude/funny-hamilton-3j8jve
Oct 13, 2026
Merged

mmcky merged 1 commit into
mainfrom
claude/funny-hamilton-3j8jve

Conversation

@mmcky

@mmcky mmcky commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Since the move to conda-incubator/setup-miniconda@v4 (#101), every job that sets up conda logs this warning:

auto-activate-base is deprecated. Please use auto-activate. If your installer does not use the base environment as the default environment, also add activate-environment: base.

This renames the input in ci.yml, cache.yml and publish.yml. The value stays true.

The second half of the warning doesn't apply. The Miniconda installer's default environment is base, and each job still activates the quantecon environment through activate-environment.

This PR's own preview build runs setup-miniconda with the new input, so its log should show the warning gone and the environment set up as before.

The English repo uses the same deprecated input in its workflows, so it could take the same change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Wyb6EzbNzY5a8uuJPnDtUb


Generated by Claude Code

setup-miniconda v4 warns on every run:

  `auto-activate-base` is deprecated. Please use `auto-activate`.

Rename the input in ci.yml, cache.yml and publish.yml. The value stays
true, and the installer's default environment is base, so the second
half of the warning (add `activate-environment: base`) does not apply;
each job still activates the quantecon environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wyb6EzbNzY5a8uuJPnDtUb
Copilot AI balanced review requested due to automatic review settings October 13, 2026 04:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a consistent, low-risk rename to the documented replacement input across all three affected workflows, with the activation environment preserved.

0 open findings

What changed in this PR

This PR silences a deprecation warning emitted by conda-incubator/setup-miniconda@v4 (adopted in #101) by renaming the deprecated auto-activate-base input to its replacement auto-activate across the repository's CI workflows. The value remains true, and each job continues to activate the quantecon environment via the existing activate-environment input, so runtime behavior is unchanged.

Changes:

  • Renamed auto-activate-base: true to auto-activate: true in ci.yml, cache.yml, and publish.yml.
  • No functional change: activate-environment: quantecon remains in each job, keeping the environment setup identical.
File Description
.github/​workflows/​ci.yml Updates the preview build's conda setup to use the non-deprecated auto-activate input.
.github/​workflows/​cache.yml Updates the weekly cache build's conda setup to use auto-activate.
.github/​workflows/​publish.yml Updates the publish-to-GH-Pages job's conda setup to use auto-activate.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants