[bsp][spacemit/k1] first version by GuEe-GUI · Pull Request #11132 · RT-Thread/rt-thread

GuEe-GUI · 2026-01-11T12:57:16Z

拉取/合并请求描述：(PR description)

[
Part of https://github.com//pull/10320
New BSP for spacemit/k1

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2026-01-11T12:57:24Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

Use workflow from 保持默认分支（通常为 master）
Keep the default branch (usually master) in Use workflow from
在 branch 输入框填写 PR 分支 riscv_dm
Enter PR branch riscv_dm in the branch field
设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将作为独立提交推送至你的分支。
The formatting changes will be pushed to your branch as a separate commit.

完成后，提交将自动更新至 riscv_dm 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the riscv_dm branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

Copilot

Pull request overview

This PR introduces the first version of a new Board Support Package (BSP) for the Spacemit K1 platform to RT-Thread. The changes add comprehensive driver support across multiple hardware subsystems including SPI, GPIO, power management, reset control, and various peripheral devices.

Changes:

New BSP infrastructure for Spacemit K1 platform
Driver implementations for SPI/QSPI, GPIO, thermal, serial, RTC, reset controller, regulators, PWM, power management, pinctrl, mailbox, and input devices
Multi-Function Device (MFD) support for Spacemit PMIC
SoC-specific support including remote processor, TCM memory, and SoC information

Reviewed changes

Copilot reviewed 96 out of 162 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
bsp/spacemit/dm/thermal/*	Thermal management driver for K1X
bsp/spacemit/dm/spi/*	SPI and QSPI controller drivers
bsp/spacemit/dm/soc/*	SoC info, IPI, TCM, and remote processor support
bsp/spacemit/dm/serial/*	PXA UART driver with DMA support
bsp/spacemit/dm/rtc/*	Spacemit PMIC RTC driver
bsp/spacemit/dm/reset/*	K1X reset controller driver
bsp/spacemit/dm/regulator/*	PMIC power regulator driver
bsp/spacemit/dm/pwm/*	PXA PWM driver
bsp/spacemit/dm/power/*	Reboot mode handler
bsp/spacemit/dm/pmdomain/*	Power domain controller
bsp/spacemit/dm/pinctrl/*	PMIC pinctrl driver
bsp/spacemit/dm/pin/*	K1X GPIO driver
bsp/spacemit/dm/mfd/*	Spacemit PMIC MFD driver
bsp/spacemit/dm/mailbox/*	K1X mailbox driver
bsp/spacemit/dm/input/*	PMIC power key input driver
bsp/spacemit/dm/include/*	TCM memory allocation header

GuEe-GUI · 2026-10-19T06:47:49Z

@Rbb666 SPACEMIT K1 已在新版本 RISC-V 上验证通过

github-actions · 2026-10-19T07:03:11Z

MemBrowse Memory Report · Explore what changed →

No memory changes detected for:

_{Catch memory regressions in CI with MemBrowse. Free for open source.}

Copilot

🟡 Changes recommended

Unresolved critical and moderate driver defects affect memory safety, interrupt initialization, voltage programming, PWM behavior, and error handling.

13 open issues

Preserve signed PMIC read errors on RV64 · New
Propagate DDR parent-switch failures · New
Preserve PWM duty cycle while disabled · New
Correct the secondary-channel bit test · New
Handle partial PWM updates safely · New
Release only valid clock handles · New
Release only valid reset handles · New
Handle PWM registration failures · New
Validate device-tree CPU indices · New
Clear freed heap pointers · New
Report the configured 3.3 V ADC reference · New
Update PWM enabled state only on success · New
Preserve PWM configuration errors during restoration · New

_{Review effort: Balanced}

Signed-off-by: GuEe-GUI <2991707448@qq.com>

rt_hw_atomic_compare_exchange_strong() reused the expected-value register for the store-conditional status. When sc failed, the retry compared against the failure status instead of the original expected value, violating strong compare-exchange semantics. This could make completion wakeup treat an uncompleted state as a waiting thread pointer and call rt_thread_resume(NULL). Keep the expected value separate from the sc status and use early-clobber constraints to prevent outputs from overlapping inputs still needed by the assembly. Validation: - Built the SpacemiT K1 BSP with the RISC-V64 musl GCC toolchain. - Verified the generated CAS instructions by disassembly. Signed-off-by: GuEe-GUI <2991707448@qq.com>

github-actions · 2026-10-19T10:09:49Z

📌 Code Review Assignment

🏷️ Tag: workflow

Reviewers: @Rbb666 @kurisaW @supperthomas

Changed Files (Click to expand)

.github/ALL_BSP_COMPILE.json
.github/workflows/bsp_buildings.yml

📊 Current Review Status (Last Updated: 2026-10-19 18:09 CST)

⌛ @Rbb666 Pending Review
⌛ @kurisaW Pending Review
⌛ @supperthomas Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

GuEe-GUI · 2026-10-19T10:18:04Z

@Rbb666 Copilot 相关审核建议已处理，CI已添加

github-actions Bot added BSP Arch: RISC-V BSP related with risc-v libcpu Component component: drivers/cputime component: drivers/ktime component: drivers labels Jan 11, 2026

Rbb666 requested a review from Copilot January 12, 2026 09:11

Copilot AI reviewed Jan 12, 2026

View reviewed changes

GuEe-GUI mentioned this pull request Mar 10, 2026

[Feature] RISC-V 近期调整 #11246

Open

13 of 31 tasks

GuEe-GUI force-pushed the riscv_dm branch 3 times, most recently from 06926c3 to 7be2a4c Compare August 29, 2026 16:29

GuEe-GUI force-pushed the riscv_dm branch from 7be2a4c to 56f7859 Compare September 29, 2026 11:51

GuEe-GUI force-pushed the riscv_dm branch 2 times, most recently from 61214e8 to cc5f733 Compare October 19, 2026 06:46

github-actions Bot added the component: drivers/core label Oct 19, 2026

Rbb666 requested a balanced review from Copilot October 19, 2026 07:59

Copilot started reviewing on behalf of Rbb666 October 19, 2026 07:59

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

GuEe-GUI force-pushed the riscv_dm branch from cc5f733 to 02aecd2 Compare October 19, 2026 10:01

GuEe-GUI added 4 commits October 19, 2026 18:09

[bsp][spacemit/k1] first version

10e7dd4

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[dm][power domain] fixup the proxy parse

2625b52

Signed-off-by: GuEe-GUI <2991707448@qq.com>

[dm][dvfs] clear the OPP warning when repeat

7a29f35

Signed-off-by: GuEe-GUI <2991707448@qq.com>

GuEe-GUI force-pushed the riscv_dm branch from 02aecd2 to e8f15d0 Compare October 19, 2026 10:09

GuEe-GUI requested a review from supperthomas as a code owner October 19, 2026 10:09

GuEe-GUI requested a review from kurisaW as a code owner October 19, 2026 10:09

github-actions Bot added the action github action yml imporve label Oct 19, 2026

Rbb666 approved these changes Oct 19, 2026

View reviewed changes

Rbb666 merged commit 1c801ef into RT-Thread:master Oct 19, 2026
110 of 111 checks passed

Conversation

GuEe-GUI commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions Bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 操作步骤 | Steps

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuEe-GUI commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report · Explore what changed →

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

📌 Code Review Assignment

🏷️ Tag: workflow

📊 Current Review Status (Last Updated: 2026-10-19 18:09 CST)

📝 Review Instructions

Uh oh!

GuEe-GUI commented Oct 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GuEe-GUI commented Jan 11, 2026 •

edited

Loading

github-actions Bot commented Jan 11, 2026 •

edited

Loading

github-actions Bot commented Oct 19, 2026 •

edited

Loading