Skip to content

use is.numeric(x) instead of is.integer(x) || is.double(x) - #7928

Merged
ben-schwen merged 1 commit into
masterfrom
linter_is.numeric
Oct 18, 2026
Merged

ben-schwen merged 1 commit into
masterfrom
linter_is.numeric

Conversation

@ben-schwen

@ben-schwen ben-schwen commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Make linter happy for failing code quality pipeline.

@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (10bfd70) to head (e069e48).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7928   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          88       88           
  Lines       17387    17387           
=======================================
  Hits        17217    17217           
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
  • HEAD=linter_is.numeric much slower for isoweek improved in #7144

Comparison Plot

Generated via commit e069e48

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 57 seconds
Installing different package versions 13 minutes and 48 seconds
Running and plotting the test cases 5 minutes and 38 seconds

@ben-schwen
ben-schwen merged commit c838f30 into master Oct 18, 2026
14 checks passed
@ben-schwen
ben-schwen deleted the linter_is.numeric branch October 18, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant