Repository navigation
Gforce single thread - #7929
Open
ben-schwen wants to merge 4 commits into
Open
Gforce single thread#7929ben-schwen wants to merge 4 commits into
ben-schwen wants to merge 4 commits into
Conversation
With one thread, use a single batch and put as much of the group id into low as fits in uint16_t. For up to 65536 groups there is then a single high bucket, gather() returns x itself instead of copying it, and gsum and gmean reduce to direct loops.
With one thread, use a single batch and put as much of the group id into low as fits in uint16_t. For up to 65536 groups there is then a single high bucket, gather() returns x itself instead of copying it, and gsum and gmean reduce to direct loops.
…data.table into gforce_single_thread
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7929 +/- ##
==========================================
+ Coverage 99.02% 99.08% +0.06%
==========================================
Files 88 88
Lines 17387 17408 +21
==========================================
+ Hits 17217 17249 +32
+ Misses 170 159 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=gforce_single_thread Generated via commit 47da9f1 Download link for the artifact containing the test results: ↓ atime-results.zip
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3330