Repository navigation
capture missing() of arguments once as flags in [ - #7932
Open
ben-schwen wants to merge 1 commit into
Open
ben-schwen wants to merge 1 commit into
ben-schwen wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## brk/a1_tests #7932 +/- ##
=============================================
Coverage 99.09% 99.09%
=============================================
Files 88 88
Lines 17420 17430 +10
=============================================
+ Hits 17262 17272 +10
Misses 158 158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-schwen
force-pushed
the
brk/a2_missing_flags
branch
from
October 21, 2026 12:07
353fbce to
a8fcf6a
Compare
ben-schwen
force-pushed
the
brk/a2_missing_flags
branch
2 times, most recently
from
October 24, 2026 23:13
cba9c55 to
391abec
Compare
(Plot image upload to picrd.com failed; download the artifact below to view plots) Generated via commit 8e8d36b Download link for the artifact containing the test results: ↓ atime-results.zip
|
| list(.j = substitute(j)) | ||
| )) | ||
| if (missing(jsub)) {j = substitute(); jsub=NULL} else if (verbose && !is.null(env)) catf("Argument '%s' after substitute: %s\n", "j", deparse1(jsub, collapse="\n")) | ||
| if (missing(jsub)) {j = substitute(); jsub=NULL; missing_j=TRUE} else if (verbose && !is.null(env)) catf("Argument '%s' after substitute: %s\n", "j", deparse1(jsub, collapse="\n")) |
Member
There was a problem hiding this comment.
how can we have !missing(j) && missing(jsub)? something like [, j = expr, env = alist(j=)]?
MichaelChirico
approved these changes
Oct 26, 2026
missing() works in the calling frame so it blocks moving code out of [.data.table. Capture it once at the top as missing_<arg> flags and keep them in sync where an argument is reassigned. No behaviour change.
ben-schwen
force-pushed
the
brk/a2_missing_flags
branch
from
October 26, 2026 15:13
391abec to
8e8d36b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #852