Repository navigation
move the cedta fallback outside of [ - #7936
Open
ben-schwen wants to merge 1 commit into
Open
ben-schwen wants to merge 1 commit into
ben-schwen wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## brk/a4_move_helpers #7936 +/- ##
====================================================
Coverage 99.09% 99.09%
====================================================
Files 88 88
Lines 17422 17422
====================================================
Hits 17264 17264
Misses 158 158 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-schwen
force-pushed
the
brk/a5_cedta_helper
branch
2 times, most recently
from
October 24, 2026 23:13
2bf339a to
effc48f
Compare
(Plot image upload to picrd.com failed; download the artifact below to view plots) Generated via commit 301e163 Download link for the artifact containing the test results: ↓ atime-results.zip
|
No behaviour change.
ben-schwen
force-pushed
the
brk/a5_cedta_helper
branch
from
October 26, 2026 15:13
effc48f to
301e163
Compare
| # Throw a specific error message | ||
| stopf("[ was called on a data.table in an environment that is not data.table-aware (i.e. cedta()), but '%s' was used, implying the owner of this call really intended for data.table methods to be called. See vignette('datatable-importing') for details on properly importing data.table.", as.character(jsub[[1L]])) | ||
| } | ||
| Nargs = nargs - (!missing_drop) |
Member
There was a problem hiding this comment.
Can we re-compute missing(drop) here? (and missing_i?)
Since this is an "unsupported" path it's fine to have a little overhead, I think it's preferable to have a minimal helper signature.
I also wonder if a do.call(`[.data.frame`, list(...)) approach could simplify(?) this arg-checking logic.
MichaelChirico
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #852