Repository navigation
Add aruco_ros - #107
Merged
Merged
Add aruco_ros#107
Conversation
Ports RoboStack/ros-lyrical#87. The patches make aruco build with OpenCV 5 and Eigen 5 from conda-forge (version requirement, top-level headers, cv::Error::Code exceptions, Eigen3::Eigen), and fix aruco_ros' hard-coded opencv4/ include. jazzy and lyrical (5.0.5) also carry the PR's target_link_libraries / tf2 .hpp changes for aruco_ros; humble and rolling (5.0.6) have those upstream. Co-authored-by: Kamil Baradziej <49471097+baradejoo@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turns the local checks of this PR into a recipe test, so later rebuilds keep them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The selection line was added twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… [skip ci] The aruco patch was the same in all four distributions, so it moves to shared/. aruco_ros's has two versions, for 5.0.6 (humble, rolling) and 5.0.5 (jazzy, lyrical): the 5.0.6 one becomes the shared patch and jazzy and lyrical keep theirs, until they get 5.0.6 too. Every distribution still gets the same patch content as before (checked against each sync's source). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Export all symbols of the aruco and aruco_ros_utils libraries on Windows (aruco only dllexports with ARUCO_DSO_EXPORTS, which its CMake never sets). Recipe test on Windows: the single executable is installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
added
build:humble
Tobias-Fischer
added
build:rolling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports RoboStack/ros-lyrical#87 by @baradejoo: adds
aruco_ros(witharuco,aruco_msgs) to the shared selection, on all platforms.aruco: builds with OpenCV 5 / Eigen 5 from conda-forge (no OpenCV version requirement, top-levelopencv2/*.hppheaders,cv::Exceptionwithcv::Error::Code,Eigen3::Eigen). The PR's patch for 5.0.5 (jazzy, lyrical), refreshed for 5.0.6 (humble, rolling).arucoandaruco_rosexport all symbols (CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS,shared/pkg_additional_info.yaml).aruco_ros: the hard-codedopencv4/opencv2/calib3d.hppinclude; for 5.0.5 also the PR'starget_link_libraries/tf2.hppchanges, which 5.0.6 has upstream.Recipe test:
single(the marker detector) starts and keeps running (shared/tests/ros2-aruco-ros.yaml).Patch layout:
shared/patch/ros2-aruco.patch(all distributions) andshared/patch/ros2-aruco-ros.patch(5.0.6: humble, rolling); jazzy and lyrical (5.0.5) keep their ownros2-aruco-ros.patchuntil they get 5.0.6.Built locally
aruco,aruco_msgs,aruco_rosincl. their recipe tests; thesingle,double,marker_publisherexecutables are installed andsinglestarts.aruco,aruco_msgs,aruco_ros(5.0.6 patches) incl. recipe tests.aruco,aruco_msgs,aruco_rosincl. recipe tests.aruco,aruco_msgs,aruco_rosincl. recipe tests.CI: full PR build green on humble, jazzy, lyrical and rolling, all platforms (linux-64, linux-aarch64, osx-64, osx-arm64, win-64). The rosdistro syncs this was prepared on are merged.
🤖 Generated with Claude Code