Repository navigation
Windows: Exit on all nonzero error codes, not just 1 - #176
Merged
Merged
Conversation
sea-bass
force-pushed
the
scastro/windows-exit-codes
branch
from
October 19, 2026 01:33
cf38aba to
1234119
Compare
traversaro
approved these changes
Oct 19, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on a RoboStack PR and this issue came up with a build that was exiting with a nonzero error code that was not 1... so figured we should fix this.
Note, however, that if we bring this version of vinca into RoboStack we will start getting failures bubble up that we will have to fix. It's a good thing, but just a heads up.