Repository navigation
fix: strip the ros2- prefix from GHA job names too, and list each package once - #177
Merged
Tobias-Fischer merged 1 commit intoOct 22, 2026
Conversation
…kage once With package_name_mode: both a batch mixes ros2-<pkg> recipes and their ros-<distro>-<pkg> compatibility recipes. Only the latter lost their prefix, so job names read e.g. "ros2-rosidlcpp rosidlcpp-typesupport-c ..." and listed a package twice when both recipes shared a batch. Strip either exact prefix (still not the first dash-separated segments, see RoboStack#141) and drop duplicates, so every job lists plain package names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
traversaro
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
package_name_mode: both, a build batch mixesros2-<pkg>recipes and theirros-<distro>-<pkg>compatibility recipes.get_stage_nameonly stripped theros-<distro>-prefix (#141), so the GitHub Actions job names read likeThe
ros2-prefix shows on some packages and not others, and a package appears twice when both of its recipes are in the same batch.get_stage_namenow:ros-<distro>-orros2-;ros2-distro-mutexbecomesdistro-mutex, notmutex);For example,
ros2-rclcpp ros-rolling-rclcpp ros2-ament-packagebecomesrclcpp ament-package,ros2-ros2-controlbecomesros2-control, andros2clistays as it is.Only the job display names change. The job keys and build steps stay the same. The tests in
vinca/test_generate_gha.pyare updated, and all 25 pass. Ruff check and format are clean.🤖 Claude (AI assistant), on behalf of @Tobias-Fischer
🤖 Generated with Claude Code