Repository navigation
Windows: Set non-client area icon - #356
Open
AlexCharlton wants to merge 1 commit into
Open
AlexCharlton wants to merge 1 commit into
AlexCharlton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it stands, on Windows, the icon used in the non-client area (at the top left of the window) is always the default:
This PR provides a hopefully better default: We try to load the icon with the identifier "1". This is the default ID that winres uses, and is a loose convention for the application icon. If there is no such icon, Windows will fall back to the pre-existing default.
The alternative to choosing a default identifier would be to make this configurable (presumably through
WindowSettings), but I think this is overkill for a single-platform feature that has a strong enough convention to take advantage of.