Repository navigation
fix(fabric): no-op warehouse create when the name already exists - #6041
Merged
Merged
Conversation
Signed-off-by: Cortland Goffena <30168413+cmgoffena13@users.noreply.github.com>
Collaborator
|
Looking into this one |
nicksspirit
approved these changes
Oct 12, 2026
nicksspirit
left a comment
nicksspirit
left a comment
Collaborator
There was a problem hiding this comment.
Went through the 409 change. An existing warehouse returns and does nothing, and any other 409 still raises. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses part 1 of #5970
Test Plan
test_create_warehouse_already_exists_is_nooptest_create_warehouse_unrelated_conflict_still_raisesChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO