Repository navigation
Conversation
Run fork tests in a fresh pytest process with collection limited to their module. This contains the intermittent baseline Linux worker crash seen after the other isolated tests without changing production multiprocessing behavior. Signed-off-by: mday-io <mdaytn@gmail.com>
The whole-file batch still crashes in Python 3.9 after the first test passes. Give each existing fork test a fresh interpreter, preserving marker filters and assertions. Both test nodes passed 30 individual runs on Linux with Python 3.9 and 3.12. Signed-off-by: mday-io <mdaytn@gmail.com>
cmgoffena13
self-requested a review
October 15, 2026 00:20
cmgoffena13
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Model-loading fork tests intermittently segfault in Python 3.9 CI when they share a pytest process. Forked workers can inherit native state left by earlier tests.
Add a
fork_isolatedmarker and runtest_parallel_loadandtest_parallel_load_multi_repoin separate pytest processes inmake fast-test,make slow-test, andmake cicd-test.Test Plan
make style. Ran the fullmake fast-testcommand on the final PR commit on macOS with Python 3.12.13. All six pytest batches passed, with 2,860 tests passed in total, including both fork tests in separate processes.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO