Repository navigation
test(dashboard): bound Bazel workers and isolate auth streams - #4334
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
ScriptedAlchemy
enabled auto-merge
October 18, 2026 21:07
ScriptedAlchemy
disabled auto-merge
October 18, 2026 21:25
CI races local and remote TestRunner execution. The one-worker hosted run timed out after 172 of 221 files, with only 103 seconds in reported test bodies. Keep two workers to avoid cold-import assertion failures seen with four. Reserve four CPUs for the workers, transforms, coordinator, and runtime helpers, following the existing Rust test allocation. A two-CPU pinned full run timed out after 111 files. With four pinned CPUs, all 221 files and 2,137 tests pass in 215.0 seconds, averaging 241% CPU. The focused six files and 43 tests also pass. Timeout budgets are unchanged.
ScriptedAlchemy
enabled auto-merge (squash)
October 18, 2026 21:53
ScriptedAlchemy
added a commit
that referenced
this pull request
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel CI uses dynamic TestRunner execution, so the dashboard suite can run on either a remote worker or the hosted runner. The one-worker revision still timed out locally after 172 of 221 files; only 102.6s of the 300s was reported test-body time. Bound Vitest to two workers and reserve four CPUs on both paths (
cpu_count=4,cpu:4), leaving capacity for transforms, the coordinator, and runtime helper threads. This follows the existing Rust test CPU reservation pattern without changing timeout or assertion budgets.Retain the SSE isolation fixes: static imports, teardown of every test-owned stream and installed connection, EventSource restoration, fresh mocked response bodies per fetch, and an exact fake-clock retry assertion with the byte-exact Last-Event-ID check. Production code, settings, and generated contracts are unchanged.
Validation:
cpu:4execution requirement and remotecpu_count=4property.