Repository navigation
ci(windows): compile the native workspace for ready pull requests - #4358
Conversation
|
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: ScriptedAlchemy <25274700+ScriptedAlchemy@users.noreply.github.com>
aa3d292 to
b2bb1a6
Compare
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed d74895d. Windows Bazel builds now honor the existing run-heavy scope gate, so draft PRs retain the lightweight path. Ready PRs and pushes compile the native Windows workspace; full Windows tests remain available through an explicit run_os dispatch. The workflow YAML parses, and diff/commitlint checks pass. Native Windows compilation remains assigned to CI.
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed ff2342a after the native CI failure reported four agent-hosts journeys timing out at their initial code-index generation.
The failing mount reaches a concrete pre-existing text-build admission defect: it added the watermark margin to the ledger reservation and then shrank it, so a build fitting the actual headroom could be refused by the larger temporary charge. This commit reuses the reviewed #4393 implementation that sizes and charges the build atomically under the canonical ledger, plus the cgroup-headroom regression already reviewed on #4379. It retains the existing ceiling, bounded reclamation, pressure/wakeup rules, and reservation owner.
The journey helper still uses its five-second deadline, 10 ms cadence, and original generation-ready condition. It now captures bounded park, worker, pressure, and ledger evidence inside that same deadline and signals the existing scheduler's cancellation on failure. Reporting after timeout performs no new readiness waits or diagnostic reads.
Validation: the transplanted production files match #4393 byte-for-byte; the added cgroup regression matches #4379. Independent source review, pinned rustfmt, diff checks, and commitlint pass. Native behavior remains for fresh CI. The old timeout log did not include enough admission state to prove this defect caused all four failures, so the diagnostic evidence remains necessary.
Ready pull requests and pushes build every Bazel workspace target on native Windows, covering cfg(windows) code through the workspace build authority. Draft pull requests skip this heavy lane. Full Windows tests remain opt-in through workflow_dispatch with run_os=true.
The native Windows lane replaces the Linux Cargo cross-check and its Cargo/MinGW-only setup. The job retains the required
Test Windowscheck name so branch protection recognizes its result.Validation on
90e5390c5c10e2e172c6b4896a5404bc6da77f67: full hosted CI passed, including the native Windows workspace build underTest Windows, Linux fleet and aggregate, Clippy, shipped CLI, repository gates, dashboard, feature gates, and benchmark self-tests. The dispatch-only Windows test step was skipped as intended; the native workspace build executed successfully. Merge whitespace and commit-message checks passed.Fixes #4324