Skip to content

fix(release): parse npm 12 pack metadata with Node 26.12.1 - #4396

Merged
ScriptedAlchemy merged 8 commits into
masterfrom
renovate/node-26.x
Oct 22, 2026
Merged

ScriptedAlchemy merged 8 commits into
masterfrom
renovate/node-26.x

Conversation

@renovate

@renovate renovate Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Update the release workflow's Node pin from 26.12.0 to 26.12.1 and fix SDK artifact discovery for the pinned npm 12.2.0. npm pack --json returns a package-name-keyed object; indexing it as an array prevented release packaging from finding the tarball.

The helper reads that object from stdin, requires exactly one package with a nonempty filename, and reports malformed metadata as a failure. The workflow requires a nonempty tarball before staging it. A subprocess regression covers filename extraction, and SDK-conformance path triggers include the helper.

Validation and readiness on 03f41646f6d2a56c27ac8136ab23604f7a597321:

  • Repository gates, Clippy, Dashboard, feature gates, benchmark self-tests, and the shipped Linux CLI build passed.
  • The package-keyed JSON shape was checked against npm CLI 12.2.0's pack command and tar logging implementation.
  • The Linux fleet and aggregate result both passed in CI run 39743657380. The full workflow completed successfully on the reviewed head.

@changeset-bot

changeset-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 03f4164

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@renovate

renovate Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) October 22, 2026 00:13
@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) October 22, 2026 02:06
@ScriptedAlchemy ScriptedAlchemy changed the title chore(deps): update dependency node to v26.12.1 fix(release): parse npm 12 pack metadata with Node 26.12.1 Oct 22, 2026
@ScriptedAlchemy
ScriptedAlchemy merged commit 874ca43 into master Oct 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant