Skip to content

[Refactor] Simplify isVSCode implementation - #8358

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-simplify-is-vscode-2799281686358303100
Draft

[Refactor] Simplify isVSCode implementation#8358
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-simplify-is-vscode-2799281686358303100

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

What has changed?

Refactored isVSCode in packages/cli-kit/src/public/node/vscode.ts to pass .vscode directly as target to findPathUp using {cwd: root} option and returning Boolean(config) directly.

How to test your changes?

CI


PR created automatically by Jules for task 2799281686358303100 started by @gonzaloriestra

Pass `.vscode` directly as the search target to `findPathUp` with `{cwd: root}` option, eliminating unnecessary path joining and removing redundant `fileExists` check.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant