Repository navigation
chore(release): 3.4.1 - #130
Merged
Merged
Conversation
lelia
had a problem deploying
to
socket-firewall
October 21, 2026 02:23 — with
GitHub Actions
Failure
lelia
force-pushed
the
dc-larsen/emudhra-ca-trust
branch
from
October 21, 2026 02:51
fe2451d to
8e82296
Compare
lelia
force-pushed
the
lelia/release-3.4.1
branch
from
October 21, 2026 02:52
42e477a to
b387d57
Compare
lelia
had a problem deploying
to
socket-firewall
October 21, 2026 02:52 — with
GitHub Actions
Failure
lelia
had a problem deploying
to
socket-firewall
October 21, 2026 03:13 — with
GitHub Actions
Failure
lelia
force-pushed
the
lelia/release-3.4.1
branch
from
October 21, 2026 20:39
0b5ff6c to
b781ad0
Compare
lelia
force-pushed
the
lelia/release-3.4.1
branch
from
October 21, 2026 21:46
73a58ee to
b79d835
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Stamps [Unreleased] as [3.4.1], bumps the version files and uv.lock, and synchronizes the current-release references across README.md and docs/**. Also bumps the Socket Python CLI in the heavy and app-tests images from 2.9.0 to 2.11.2, which carries the eMudhra CA fix for the CLI's own image.
Points all three images at the trivy-dist toolchain rebuild of v0.73.0 on Go 1.26.10 (SocketDev/trivy-dist#24). The digest is a placeholder until that image is published. check_core_tools now ranks -socket.N GHCR tags above their base version and drops the suffix from the upstream Go module purl.
Upstream's v0.76.1 is built on Go 1.27.3, so Basics takes Socket's build of it instead of a 0.73.0 toolchain rebuild (SocketDev/trivy-dist#25). The digest stays a placeholder until that build publishes.
uv.lock moves once socketdev 3.6.1 is on PyPI.
2.11.3 requires certifi>=2026.10.19 and SDK 3.6.1, which requires it too. Relocked with uv 0.12.1, the version the images use, which also restores lock format revision 3.
lelia
force-pushed
the
lelia/release-3.4.1
branch
from
October 21, 2026 21:53
b4cd6fe to
c70dc73
Compare
lelia
had a problem deploying
to
socket-firewall
October 21, 2026 21:53 — with
GitHub Actions
Failure
lelia
marked this pull request as ready for review
October 21, 2026 21:57
David Larsen (dc-larsen)
approved these changes
Oct 22, 2026
Douglas (dacoburn)
approved these changes
Oct 22, 2026
Douglas (dacoburn)
left a comment
Contributor
There was a problem hiding this comment.
Nothing jumps out to me as an issue here.
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2a8e43b. Configure here.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release for the eMudhra intermediate CA compromise. Builds on #128, which is merged.
Ready for review. Trivy 0.76.1 is published and pinned, CI is green, and the final images pass the checks below. Ready to merge once approved.
What's in it
ca-certificates20250419+deb13u1, Node 22.23.4, pip 26.2.2 and certifi 2026.10.19 or newer, and source installs require the same certifi.uv.lock. Both requirecertifi>=2026.10.19(Stop trusting the compromised eMudhra intermediate CAs socket-python-cli#415, #418; Releasev3.6.1: patchedcertifi,uvandvirtualenv; requirecertifi>=2026.10.19socket-sdk-python#120). Relocked with uv 0.12.1, the version the images use, so the lock format stays at revision 3 likemain.ghcr.io/socketdev/trivy:0.76.1@sha256:883da3593a60e311b2ed87c3a55241051b27bba15ffc3ce041ae570cd0f00915in all three Dockerfiles. The image tag,TRIVY_VERSION, tests and docs are updated.check_core_tools.pykeeps its-socket.Nsupport for future toolchain rebuilds.scripts/prep_release.py --version 3.4.1: version files,uv.lock,action.yml(socket-basics:3.4.1), README and docs.check_release_docs.py --checkandsync_release_version.py --checkpass.Not in this release: TruffleHog stays on 3.96.0 (go1.25.12). No release is built on a fixed Go yet (3.99.3 is go1.27.2). Its runtime trust is fixed by the system store from #128, so this only affects scanner findings for CVE-2026-111943, which the changelog notes.
Before this ships
main.0.76.1(run). The image is cosign-signed by the trivy-dist workflow, its binaries are go1.27.3 on amd64 and arm64, and it carriesca-certificates20261020-r0. Pinned in all three Dockerfiles; placeholders and TODOs removed.Dockerfile,Dockerfile.heavyandapp_tests/Dockerfilelocally.smoke-test-docker.sh(all three check sets) andintegration-test-docker.sh(main and heavy) pass, CI smoke passes on amd64 and arm64, and every check under "Verification" below rejects both test hosts in the main and heavy images. Heavy reports socketcli 2.11.3, certifi 2026.10.19, pip 26.2.2, Node 22.23.4, Trivy 0.76.1.v3.4.1to publish.Verification for the final build
On the published
3.4.1and3.4.1-heavyimages, every client should fail certificate verification against bothdv-g3b-emudhra.we-have-a-problem.comanddv-g3b-aaa-emudhra.we-have-a-problem.com:Each line should fail verification. pip should print
CERTIFICATE_VERIFY_FAILED. Use/usr/local/bin/pythonfor pip, because the.venv(first onPATH) has no pip. Local builds of this branch pass all of these for both images.The app-tests image (internal integration testing only, not published) now gets the same
ca-certificatesfloor and pip 26.2.2 upgrade as the shipped images. Its pip previously stayed at the base image's 25.0.1, which accepted the test hosts.Note
Medium Risk
Security-sensitive supply-chain and TLS trust changes across Docker images and pinned scanners/SDKs; behavior is intentional but affects what CI images pull and how certificate verification behaves at build/runtime.
Overview
Release 3.4.1 hardens images and dependencies after the compromised eMudhra intermediate CAs, and bumps the published GitHub Action and GHCR image to
3.4.1.Dependency and image pins: Socket-built Trivy moves 0.73.0 → 0.76.1 (digest-pinned in
Dockerfile,Dockerfile.heavy, andapp_tests/Dockerfile) so the bundled scanner uses Go 1.27.3 and clears CVE-2026-111943 findings on Trivy itself. Socket Python CLI is 2.9.0 → 2.11.3 in heavy and app-tests images; socketdev is 3.6.0 → 3.6.1 inuv.lock, both aligned withcertifi>=2026.10.19.Build and tooling: The internal app-tests image now enforces the same
ca-certificatesfloor and pip ≥26.2.2 upgrade as shipped images (pip previously stayed on the base image and could still trust bad chains).scripts/check_core_tools.pyunderstands TrivyX.Y.Z-socket.Nrebuild tags for GHCR discovery and upstream PURL scoring, with matching tests.Release mechanics: Version strings,
action.yml, README/docs examples, and the changelog are updated for 3.4.1; changelog notes TruffleHog may still trigger CVE-2026-111943 until rebuilt on a fixed Go.Reviewed by Cursor Bugbot for commit 2a8e43b. Configure here.