Repository navigation
fix(manifest): write JVM Socket facts into the build's own root - #1590
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 2 commits intoOct 8, 2026
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 2 commits into
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 2 commits into
Conversation
mvn -f sub/x.xml and gradle -p dir wrote the facts file to cwd, where its build-root-relative paths do not resolve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
Jeppe Fredsgaard Blaabjerg (jfblaa)
marked this pull request as ready for review
October 8, 2026 10:00
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3e2edef. Configure here.
Oskar Haarklou Veileborg (BarrensZeppelin)
added this pull request to stack #1592
October 8, 2026 10:38
# Conflicts: # CHANGELOG.md
Martin Torp (mtorp)
approved these changes
Oct 8, 2026
Jeppe Fredsgaard Blaabjerg (jfblaa)
deleted the
jfblaa/facts-build-root
branch
October 8, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

LLM Description written by Claude Code:claude-opus-5-5
Second step of the #1587 stack. The Maven, Gradle and sbt scripts now report the build's root directory, and the facts file is written there. Previously
mvn -f sub/x.xmlorgradle -p dirwrote it to cwd, where its build-root-relative paths don't resolve. The file name is unchanged.buildRootrecord from all three scripts. A build that doesn't report one fails instead of guessing.--dynamic-sbom-inference) resolvessubprojectDiragainst the build root, and only counts a module as covered when it is the build root or inside it. A module that escapes a relocated reactor still gets its own run.No Coana dependency.
Stack: #1589 → this → #1591 → #1587
🤖 Generated with Claude Code
Note
Medium Risk
Changes where facts files land and how monorepo discovery classifies coverage; incorrect buildRoot reporting would break path resolution or skip/generate the wrong modules.
Overview
Fixes JVM Socket facts placement when the build is rooted away from the CLI working directory (
mvn -f,gradle -p). Maven, Gradle, and sbt now emit abuildRootline in their records protocol; the CLI writes.socket.facts.jsonthere (not incwd) and fails closed if the tool does not report a root.Recursive manifest discovery (
--dynamic-sbom-inference) resolvessubprojectDiragainst that reported build root and treats nested coverage relative tobuildRoot, not the discovery directory—so relocated reactors still skip in-tree modules correctly while sibling/escaped modules keep their own run.Changelog documents the fix; unit tests cover parsing, write location, missing
buildRoot, and relocated-root coverage.Reviewed by Cursor Bugbot for commit 3e2edef. Configure here.